<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for review.<br>
</p>
<div class="moz-cite-prefix">On 18.02.2025 14:10, Sergey Kaplun via
Tarantool-patches wrote:<br>
</div>
<blockquote type="cite" cite="mid:Z7RqlBVAaN9wuboj@root">
<pre wrap="" class="moz-quote-pre">Hi, Sergey!
Thanks fro the patch!
LGTM, except a minor nits below.
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">sysprof: align test title with test filename
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
It should be `test:`, since we don't change the sysprof component
itself, only test for it.
</pre>
</blockquote>
Fixed.<br>
<blockquote type="cite" cite="mid:Z7RqlBVAaN9wuboj@root">
<pre wrap="" class="moz-quote-pre">
On 13.02.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">The patch fixes TAP test title to make it aligned with test
filename. Inconsistency introduced in commit
efd7e1a67de24464e1e83793e16eac6df443e3c0
("test: make skipcond helper more convenient").
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
I am afraid that this naming was introduced in the first commit related
to the tests (sysprof and memprof).
</pre>
</blockquote>
<p>No. The test introduced in
2593a9f83072ca999d5f528e1da481e8ba51d5b8,</p>
<p>when test titles were not supported.<br>
</p>
<blockquote type="cite" cite="mid:Z7RqlBVAaN9wuboj@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">---
test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +-
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Should it be fixed for the memprof too?</pre>
</blockquote>
<p>Fixed:</p>
<p>---
a/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua<br>
+++ b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua<br>
@@ -1,7 +1,7 @@<br>
-- XXX: This comment is a reminder to reimplement memprof tests<br>
-- assertions to make them more independent to the changes made.<br>
local tap = require("tap")<br>
-local test = tap.test("misc-memprof-lapi"):skipcond({<br>
+local test = tap.test("misclib-memprof-lapi"):skipcond({<br>
['Test requires JIT enabled'] = not jit.status(),<br>
['Disabled on *BSD due to #4819'] = jit.os == 'BSD',<br>
["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86"
and<br>
</p>
<blockquote type="cite" cite="mid:Z7RqlBVAaN9wuboj@root">
<pre wrap="" class="moz-quote-pre">
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre"> 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
index 237143ad..32fa384c 100644
--- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
+++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
<snipped>
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">--
2.34.1
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>