<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey!</p>
<p>thanks for review! Fixed and force-pushed.<br>
</p>
<div class="moz-cite-prefix">On 10.02.2025 17:51, Sergey Kaplun via
Tarantool-patches wrote:<br>
</div>
<blockquote type="cite" cite="mid:Z6oSdGtqeupqFb0B@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the patch!
LGTM, with a few nits below regarding the commit message.
On 04.02.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">The patch fixes inconsistency in comment and source code below
the comment. The typo was added in the initial commit
2593a9f83072 ("misc: introduce Lua API for new sampling profiler").
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Please use the full commit hash.</pre>
</blockquote>
Fixed.<br>
<blockquote type="cite" cite="mid:Z6oSdGtqeupqFb0B@root">
<pre class="moz-quote-pre" wrap="">
I know that this is enough too, but:
a) It would be consistent with other commit messages.
b) There is less probability of the collision between hashes.
Maybe it is worth to mention "Follows up tarantool/tarantool#781" (the
sysprof ticket) if you want (I am not sure that this is needed, since it
is only the comment).</pre>
</blockquote>
Added.<br>
<blockquote type="cite" cite="mid:Z6oSdGtqeupqFb0B@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">---
src/lib_misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib_misc.c b/src/lib_misc.c
index ca1d1c75..5b7a4b62 100644
--- a/src/lib_misc.c
+++ b/src/lib_misc.c
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">--
2.34.1
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>