<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for review! Changes force-pushed.</p>
<p>Sergey<br>
</p>
<div class="moz-cite-prefix">On 29.01.2025 17:55, Sergey Kaplun via
Tarantool-patches wrote:<br>
</div>
<blockquote type="cite" cite="mid:Z5pBVDYaRHaRom7Z@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the patch!
LGTM, with a minor comment below.
On 29.01.25, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">The macros `UNUSED` is widely used across the suite
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Typo: s/macros/macro/</pre>
</blockquote>
Fixed.<br>
<blockquote type="cite" cite="mid:Z5pBVDYaRHaRom7Z@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">`tarantool-c-tests`. The patch defines macros only once in
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Typo: s/macros/macro/</pre>
</blockquote>
Fixed.
<blockquote type="cite" cite="mid:Z5pBVDYaRHaRom7Z@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">`test.h` to reuse it in other tests and removes definitions in
tests.
---
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/ligurio/gh-xxxx-define-unused">https://github.com/tarantool/luajit/tree/ligurio/gh-xxxx-define-unused</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">diff --git a/test/tarantool-c-tests/test.h b/test/tarantool-c-tests/test.h
index 3b22fb92..c1717932 100644
--- a/test/tarantool-c-tests/test.h
+++ b/test/tarantool-c-tests/test.h
@@ -4,6 +4,8 @@
#include <stdio.h>
#include <stdlib.h>
+#define UNUSED(x) ((void)(x))
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Minor: I suggest to wrapping this into the `#ifndef`, since the
`UNUSED()` is a very common macro. The same one is used in the LuaJIT.
For now these macros are the same [1] but to avoid rewriting code in the
case of the changes, it is better to use `#ifndef` directive here.</pre>
</blockquote>
<p>Updated:</p>
<p>--- a/test/tarantool-c-tests/test.h<br>
+++ b/test/tarantool-c-tests/test.h<br>
@@ -4,7 +4,9 @@<br>
#include <stdio.h><br>
#include <stdlib.h><br>
<br>
+#ifndef UNUSED<br>
#define UNUSED(x) ((void)(x))<br>
+#endif<br>
<br>
/*<br>
* Test module, based on TAP 14 specification [1].<br>
</p>
<blockquote type="cite" cite="mid:Z5pBVDYaRHaRom7Z@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+
/*
* Test module, based on TAP 14 specification [1].
* [1]: <a class="moz-txt-link-freetext" href="https://testanything.org/tap-version-14-specification.html">https://testanything.org/tap-version-14-specification.html</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
[1]: <a class="moz-txt-link-freetext" href="https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html">https://gcc.gnu.org/onlinedocs/cpp/Undefining-and-Redefining-Macros.html</a>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>