<!DOCTYPE html>
<html data-lt-installed="true">
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body style="padding-bottom: 1px;">
    <p>Hi, Sergey,<br>
    </p>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 25.09.2024 10:19, Sergey Kaplun
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:ZvO5g6ryIcyhM1vg@root">
      <pre class="moz-quote-pre" wrap="">On 24.09.24, Sergey Kaplun via Tarantool-patches wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">Hi, Sergey!

On 24.09.24, Sergey Bronnikov wrote:
</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">Hi, Sergey,


On 24.09.2024 13:29, Sergey Kaplun wrote:
</pre>
          <blockquote type="cite">
            <pre class="moz-quote-pre" wrap="">This patch removes the default adding of the tools directory to the
LUA_PATH. Now it is done only for profilers tests.

Part of tarantool/tarantool#9898
---
</pre>
          </blockquote>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
<snipped>

</pre>
        <blockquote type="cite">
          <blockquote type="cite">
            <pre class="moz-quote-pre" wrap="">@@ -163,4 +161,12 @@ foreach(test_path ${tests})
      LABELS ${TEST_SUITE_NAME}
      DEPENDS tarantool-tests-deps
    )
+
+  # The part of the profilers toolchain is located in the <tools/>
+  # directory, so LUA_PATH needs to be updated.
+  if(test_name MATCHES "^profilers")
+    AppendTestEnvVar(${test_title}
+      LUA_PATH "${PROJECT_SOURCE_DIR}/tools/?.lua\;"
+    )
+  endif()
  endforeach()
</pre>
          </blockquote>
          <pre class="moz-quote-pre" wrap="">
AFAIR, we decided to move the last hunk to profilers/CMakeLists.txt.
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
I don't remember that, unfortunately. Also, may be it is better that
this cycle handles all tests? Otherwise, we should scan that directory
again with constructing test_title again. This is why we decided to move
it in the cycle instead of the child <CMakeLists.txt> [1].

</pre>
      </blockquote>
    </blockquote>
    <p>Okay, let's leave it without changes.</p>
    <p>LGTM<br>
    </p>
    <blockquote type="cite" cite="mid:ZvO5g6ryIcyhM1vg@root">
      <blockquote type="cite">
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
[1]: <a class="moz-txt-link-freetext" href="https://lists.tarantool.org/tarantool-patches/c22c7bc2-ddaa-4b22-83ae-edba3ce73dd6@tarantool.org/T/#u">https://lists.tarantool.org/tarantool-patches/c22c7bc2-ddaa-4b22-83ae-edba3ce73dd6@tarantool.org/T/#u</a>

-- 
Best regards,
Sergey Kaplun
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
</pre>
    </blockquote>
  </body>
  <lt-container></lt-container>
</html>