<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p><br>
</p>
<div class="moz-cite-prefix">On 24.09.2024 18:23, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:ZvLZi0UQlZTSyHU2@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.
On 24.09.24, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi, Sergey,
On 24.09.2024 13:29, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This patch sets LD_PRELOAD for ASan build for the required tests instead
of all tests.
Follows up tarantool/tarantool#9898
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
probably follows up these commits as well:
commit 9f1137bcc890c28c5de24497624553574d371007 "cmake: replace prove
with CTest"
commit abe1e0aca3ad01f89f9d184c2a82949314814d04 "ci: execute LuaJIT
tests with GCC 10 and ASAN"
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I've opted the previous commit (where the corresponding FIXME is
introduced). The new commit message is:
| test: set LD_PRELOAD only when necessary
|
| As a follow-up for 888adcfb72e361b150a9038407eb1dc9bd3392bd ("test: fix
| lj-802-panic-at-mcode-protfail GCC+ASan"), this patch sets LD_PRELOAD
| for ASan build for the required tests instead of all tests.
|
| Follows up tarantool/tarantool#9898</pre>
</blockquote>
Thanks! LGTM<br>
<blockquote type="cite" cite="mid:ZvLZi0UQlZTSyHU2@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
LGTM
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">---
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>