<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey,</p>
<p>thanks for the fixes! LGTM<br>
</p>
<div class="moz-cite-prefix">On 26.08.2024 09:50, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:ZswlvE07MJbHoizD@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the review!
Fixed your comments and force-pushed the branch.
On 23.08.24, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Sergey,
On 21.08.2024 11:58, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This patch moves the aforementioned test from the <misc> to the <trace/>
directory, includes it in <index>, and names subtests.
Part of tarantool/tarantool#9398
---
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">thanks for the patch! LGTM with a minor comment
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua
new file mode 100644
index 00000000..a995921e
--- /dev/null
+++ b/test/LuaJIT-tests/trace/jit_flush.lua
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+
+
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">please remove excess newline
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Fixed, thanks!
See the iterative patch below.
===================================================================
diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua
index a995921e..4cdf2c39 100644
--- a/test/LuaJIT-tests/trace/jit_flush.lua
+++ b/test/LuaJIT-tests/trace/jit_flush.lua
@@ -52,7 +52,6 @@ do --- Flush in the loop.
jit.flush()
end
-
do --- Flushes of not existed traces.
jit.flush()
===================================================================
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+do --- Flushes of not existed traces.
+ jit.flush()
+
+ jit.flush(1) -- ignored
+ jit.flush(2) -- ignored
+ for _ = 1, 1e7 do end -- causes trace #1
+
+ jit.flush(2) -- ignored
+ jit.flush(1) -- ok
+ jit.flush(1) -- crashes
+end
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>