<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Sergey,<br>
</p>
<div class="moz-cite-prefix">On 22.08.2024 17:34, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:ZsdMfiHsRnbiKQ7t@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the review!
Please consider my answer below.
On 22.08.24, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Sergey,
On 21.08.2024 11:58, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This patch moves the aforementioned test from the <misc> to the <lang/>
directory, includes it in <index>, names the subtests, and adds testing
of the error message for all non-tail call cases.
Part of tarantool/tarantool#9398
---
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">thanks for the patch! LGTM with a minor comment below.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> test/LuaJIT-tests/lang/index | 1 +
test/LuaJIT-tests/lang/stackov.lua | 48 ++++++++++++++++++++++++++++++
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Probably filename "stack_overflow.lua" will be better. Feel free to ignore.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I prefer to leave it as is, since it is consistent with the error name
in sources, if you don't insist.</pre>
</blockquote>
Ok, let's leave it as is. LGTM as I said previously.<br>
<blockquote type="cite" cite="mid:ZsdMfiHsRnbiKQ7t@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> test/LuaJIT-tests/misc/stackov.lua | 40 -------------------------
3 files changed, 49 insertions(+), 40 deletions(-)
create mode 100644 test/LuaJIT-tests/lang/stackov.lua
delete mode 100644 test/LuaJIT-tests/misc/stackov.lua
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>