<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p><br>
</p>
<div class="moz-cite-prefix">On 21.08.2024 19:36, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:ZsYXkXxSURzGVInn@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the review!
Please consider my answers below.
On 21.08.24, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Sergey,
thanks for the patch!
On 21.08.2024 11:58, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This patch removes the aforementioned test since it is identical to the
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Line's width is 70 symbols, please split.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
The maximum line's width is 72 symbols, see [1]. It is 71 here, so
ignoring.
Side note: I use (if not forgot) the Vim auto-formatting for the gitcommit.
For the code style, it needs some tuning and configuration.
:help v_gq
</pre>
</blockquote>
Thanks! LGTM<br>
<blockquote type="cite" cite="mid:ZsYXkXxSURzGVInn@root">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
LGTM
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""><lib/coroutine/yield.lua> test, which wasn't cleaned up during the
refactoring in the original repository.
Part of tarantool/tarantool#9398
---
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap=""><snipped>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
[1]: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message">https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message</a>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>