<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Max</p>
<p>thanks for review!<br>
</p>
<div class="moz-cite-prefix">On 19.08.2024 12:45, Maxim Kokryashkin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:kxjjpuv7otur5pfel7iqr5ydt4zrh45ay2lfr33b455o7xtfpo@oraiqjeoscys">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the patch!
As this thread replies grew way beyond comprehensible limit, I'll refer
to the GitHub commit instead.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Sergey Bronnikov:
* added the description and the trimmed the test for the problem
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Typo: s/the trimmed/trimmed/
<lj-865-cross-generation-mach-o-file.test.lua>
Lines: 149-150:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">-- The function builds a Mach-O object file and retrieves its
-- header fields.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">I believe, "validates" fits better than "retrieves" here.
Line: 153:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">-- LuaJIT always generate 64-bit, non-FAT Mach-O object files.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Typo: s/generate/generates/</pre>
</blockquote>
<br>
<p>Both typos were fixed:</p>
<p><br>
</p>
---
a/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua<br>
+++
b/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua<br>
@@ -146,11 +146,11 @@ local function read_mach_o_hdr(buf, hw_arch)<br>
return mach_header<br>
end<br>
<br>
--- The function builds a Mach-O object file and retrieves its<br>
+-- The function builds a Mach-O object file and validates its<br>
-- header fields.<br>
local function build_and_check_mach_o(subtest)<br>
local hw_arch = subtest.name<br>
- -- LuaJIT always generate 64-bit, non-FAT Mach-O object files.<br>
+ -- LuaJIT always generates 64-bit, non-FAT Mach-O object files.<br>
assert(hw_arch == 'arm64')<br>
<br>
subtest:plan(5)
<blockquote type="cite"
cite="mid:kxjjpuv7otur5pfel7iqr5ydt4zrh45ay2lfr33b455o7xtfpo@oraiqjeoscys">
<pre class="moz-quote-pre" wrap="">
Otherwise, LGTM.
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>