<!DOCTYPE html>

<html data-lt-installed="true">

  <head>

    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

  </head>

  <body style="padding-bottom: 1px;">

    <p>Hi, Sergey<br>

    </p>

    <div class="moz-cite-prefix">On 17.06.2024 15:47, Sergey Kaplun

      wrote:<br>

    </div>

    <blockquote type="cite" cite="mid:ZnAwSaWt7_B92mlL@root">

      <pre class="moz-quote-pre" wrap="">Hi, Sergey!

Thanks for the patch!

Generally LGTM, but I have a couple of questions:

1) What happens if we use a feature that is introduced in 2.4 (for

example) and becomes deprecated in:

a) 2.27?

b) 2.30?</pre>

    </blockquote>

    <p>According to CMake documentation: [1]<br>

    </p>

    <p>> *All policies known to the running version of CMake and

      introduced in the <min> (or <max>, if specified)

      version or earlier will be set to use NEW behavior. All policies

      introduced in later versions will be unset.* This effectively

      requests behavior preferred as of a given CMake version and tells

      newer CMake versions to warn about their new policies.</p>

    <p>Looks acceptable for us, right?</p>

    <p>1.

<a class="moz-txt-link-freetext" href="https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-settings">https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-settings</a></p>

    <p><br>

    </p>

    <p>Also, I've updated a comment before cmake_minimum_required:</p>

    <p>--- a/CMakeLists.txt<br>

      +++ b/CMakeLists.txt<br>

      @@ -8,7 +8,16 @@<br>

       # --- Initial setup

      ------------------------------------------------------------<br>

       <br>

       # See the rationale below (near LUAJIT_TEST_BINARY variable).<br>

      -cmake_minimum_required(VERSION 3.1 FATAL_ERROR)<br>

      +# <policy_max> is set to 3.18 because compatibility with

      versions<br>

      +# of CMake older than 2.8.12 is deprecated. Calls to<br>

      +# cmake_minimum_required(VERSION) that do not specify at<br>

      +# least 2.8.12 as their policy version (optionally via

      ...<max>)<br>

      +# will produce a deprecation warning in CMake 3.19 and above [1].<br>

      +# Compatibility with 2.8.12 is needed for CMP0002 [2].<br>

      +#<br>

      +# [1]

<a class="moz-txt-link-freetext" href="https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-settings">https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-settings</a><br>

      +# [2] <a class="moz-txt-link-freetext" href="https://cmake.org/cmake/help/latest/policy/CMP0002.html">https://cmake.org/cmake/help/latest/policy/CMP0002.html</a><br>

      +cmake_minimum_required(VERSION 3.1...3.18 FATAL_ERROR)<br>

       project(LuaJIT C)<br>

       <br>

       # XXX: Originally CMake machinery is introduced to make LuaJIT</p>

    <p><br>

    </p>

    <p>and added a note to the commit message regarding compatibility</p>

    <p>with Tarantool's cmake minimum required version:</p>

    <p>  Note, that a current minimum required version in Tarantool is

      equal<br>

          to 2.8, but <policy_max> is introduced in CMake 3.12

      [2].<br>

          However, according to [2] it is not a problem, because if

      CMake is<br>

          "older than 3.12, the extra ... dots will be seen as version<br>

          component separators, resulting in the ...<max> part

      being ignored<br>

          and preserving the pre-3.12 behavior of basing policies on

      <min>".<br>

    </p>

    <blockquote type="cite" cite="mid:ZnAwSaWt7_B92mlL@root">

      <pre class="moz-quote-pre" wrap="">

2) Can we declare the minimum required version in the root

CMakeLists.txt of the project instead?</pre>

    </blockquote>

    <p>It is already done in the branch, but I haven't sent an updated</p>

    <p>version to the list. Sorry, my bad. I'll send v2 soon.<br>

    </p>

    <blockquote type="cite" cite="mid:ZnAwSaWt7_B92mlL@root">

      <pre class="moz-quote-pre" wrap="">

On 21.03.24, Sergey Bronnikov wrote:

</pre>

      <blockquote type="cite">

        <pre class="moz-quote-pre" wrap="">From: Sergey Bronnikov <a class="moz-txt-link-rfc2396E" href="mailto:sergeyb@tarantool.org"><sergeyb@tarantool.org></a>

CMake produces annoying warnings:

CMake Deprecation Warning at src/CMakeLists.txt:7 (cmake_minimum_required):

  Compatibility with CMake < 3.5 will be removed from a future version of

  CMake.

We cannot bump a minimum required CMake version without

bumping it in a Tarantool build system. However, we can set

a max supported CMake version and suppress a warning.

CMake 3.27.7 is a version used by me for a long time for

building LuaJIT. This version is tested and seen no policy warnings

with a that version.

---

Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings">https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings</a>

Doc: <a class="moz-txt-link-freetext" href="https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html">https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html</a>

NOTE: another solution is using CMAKE_WARN_DEPRECATED,

but I don't like it. Let's discuss.

1. <a class="moz-txt-link-freetext" href="https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html">https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html</a>

 CMakeLists.txt                                 | 2 +-

 etc/CMakeLists.txt                             | 2 +-

 src/CMakeLists.txt                             | 2 +-

 src/host/CMakeLists.txt                        | 2 +-

 test/CMakeLists.txt                            | 2 +-

 test/LuaJIT-tests/CMakeLists.txt               | 2 +-

 test/LuaJIT-tests/src/CMakeLists.txt           | 2 +-

 test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt      | 2 +-

 test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 2 +-

 test/lua-Harness-tests/CMakeLists.txt          | 2 +-

 test/tarantool-tests/CMakeLists.txt            | 2 +-

 tools/CMakeLists.txt                           | 2 +-

 12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt

index 7f5e2afb..9edff6f3 100644

--- a/CMakeLists.txt

+++ b/CMakeLists.txt

@@ -8,7 +8,7 @@

 # --- Initial setup ------------------------------------------------------------

 # See the rationale below (near LUAJIT_TEST_BINARY variable).

-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)

+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)

 project(LuaJIT C)

 # XXX: Originally CMake machinery is introduced to make LuaJIT

diff --git a/etc/CMakeLists.txt b/etc/CMakeLists.txt

index d54fa794..39f6df77 100644

--- a/etc/CMakeLists.txt

+++ b/etc/CMakeLists.txt

@@ -1,7 +1,7 @@

 # Building supplementary materials for LuaJIT.