<!DOCTYPE html>
<html data-lt-installed="true">
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body style="padding-bottom: 1px;">
    <p>Sergey,<br>
    </p>
    <div class="moz-cite-prefix">On 16.04.2024 18:29, Sergey Bronnikov
      via Tarantool-patches wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:052764ac-c566-4551-81e0-777c60cc7845@tarantool.org">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    </blockquote>
    <snipped><br>
    <blockquote type="cite"
      cite="mid:052764ac-c566-4551-81e0-777c60cc7845@tarantool.org"><span
      style="white-space: pre-wrap">
</span>
      <blockquote type="cite" cite="mid:ZhkYx7YWe30lu3dJ@root">
        <blockquote type="cite"> </blockquote>
        <pre class="moz-quote-pre" wrap="">Minor: we can use `subtest.name` as the definition of the `hw_arch` in the
`build_and_check_mach_o()`, so it helps to avoid duplication of arch
usage.

Matter of taste.
Feel free to ignore.
</pre>
      </blockquote>
      ignored<br>
    </blockquote>
    <p>removed additional argument with `hw_arch` and replaced with
      subtest.name:</p>
    <p><br>
    </p>
    <p>@@ -293,7 +295,8 @@ local SUM_CPUSUBTYPE = {<br>
       -- $ luajit -b -o osx -a arm64 empty.lua empty.o<br>
       -- $ lipo -archs empty.o<br>
       -- x86_64 arm64<br>
      -local function build_and_check_mach_o(subtest, hw_arch)<br>
      +local function build_and_check_mach_o(subtest)<br>
      +  local hw_arch = subtest.name<br>
         assert(hw_arch == 'arm' or hw_arch == 'arm64')<br>
       <br>
         subtest:plan(4)<br>
      @@ -341,7 +344,7 @@ local function build_and_check_mach_o(subtest,
      hw_arch)<br>
                    'cpusubtype is correct in Mach-O')<br>
       end<br>
       <br>
      -test:test('arm', build_and_check_mach_o, 'arm')<br>
      -test:test('arm64', build_and_check_mach_o, 'arm64')<br>
      +test:test('arm', build_and_check_mach_o)<br>
      +test:test('arm64', build_and_check_mach_o)<br>
       <br>
       test:done(true)<br>
    </p>
    <blockquote type="cite"
      cite="mid:052764ac-c566-4551-81e0-777c60cc7845@tarantool.org">
      <blockquote type="cite" cite="mid:ZhkYx7YWe30lu3dJ@root">
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">+
+test:done(true)
-- 
2.34.1

</pre>
        </blockquote>
      </blockquote>
      <lt-container></lt-container>
    </blockquote>
  </body>
</html>