<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey</p>
<p><br>
</p>
<p>thanks for the answer. LGTM<br>
</p>
<div class="moz-cite-prefix">On 13.06.2024 12:51, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:ZmrBKfb3hXc-22t-@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the review!
On 06.06.24, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi, Sergey
thanks for the patch! Please see a question below.
On 22.04.2024 11:49, Sergey Kaplun wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">This option enables table bump optimization if sink optimization is
enabled. The table bump optimization patches the bytecodes with a table
allocation on the trace recording if the recorded trace exceeds the size
of the allocated table. This optimization still has some bugs, so it is
disabled by default. For more details, see the comment in
<CMakeLists.txt>.
Needed for tarantool/tarantool#9924
---
CMakeLists.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2355ce17..52014296 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -307,6 +307,23 @@ if(LUAJIT_ENABLE_COVERAGE)
include(CodeCoverage)
endif()
+# Enable table bump optimization. This optimization patches the
+# bytecodes with a table allocation on the trace recording if the
+# recorded trace exceeds the size of the allocated table.
+# This optimization still has some bugs, so it is disabled by
+# default. See also:<a class="moz-txt-link-freetext" href="https://github.com/LuaJIT/LuaJIT/issues/606">https://github.com/LuaJIT/LuaJIT/issues/606</a>.
+option(LUAJIT_ENABLE_TABLE_BUMP "Enable table bump optimization" OFF)
+if(LUAJIT_ENABLE_TABLE_BUMP)
+ # Within table bump optimization enabled (and due to our
+ # modification related to metrics), some offsets in `GG_State`
+ # stop fit in 12bit immediate. Hence, the build failed due to
+ # the DASM error (DASM_S_RANGE_I).
+ if(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64")
+ message(FATAL_ERROR "Table Bump optimization is unsupported for aarch64")
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Table optimization works on all architectures supported by LuaJIT except
aarch64, right?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
In the upstream, it works on all architectures. We have a problem
building LuaJIT for aarch64 due to our metrics that too grows the
`GG_State`.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+ endif()
+ AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_TABLE_BUMP)
+endif()
+
# --- Main source tree ---------------------------------------------------------
add_subdirectory(src)
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>