<!DOCTYPE html>
<html data-lt-installed="true">
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body style="padding-bottom: 1px;">
    <p>Hi, Sergey</p>
    <p><br>
    </p>
    <p>LGTM<br>
    </p>
    <div class="moz-cite-prefix">On 13.06.2024 13:35, Sergey Kaplun
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:ZmrLjJh_Ow6njCZo@root">
      <pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 07.06.24, Sergey Bronnikov wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">Sergey,


thanks for the patch! See my comments below.

Sergey

On 15.05.2024 15:32, Sergey Kaplun wrote:
</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">Relates to tarantool/tarantool#8473
---
  .github/workflows/sanitizers-testing.yml | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
index 154ebe40..4bf7d023 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml
</pre>
        </blockquote>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
<snipped>

</pre>
      <blockquote type="cite">
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">@@ -91,5 +92,8 @@ jobs:
              symbolize=1:                     \
              unmap_shadow_on_exit=1:          \
            "
+          UBSAN_OPTIONS: "
+            print_stacktrace=1 \
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">I propose to move these env variables to CMake.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
I suppose this is the same reason as for ASAN options: when run the asan
+ lsan CI in the tarantool repository, it configures its own ASAN +
UBSAN options. To avoid their overwriting in our CMake file, we don't
include this part there.
</pre>
    </blockquote>
    Got it, thanks!<br>
    <blockquote type="cite" cite="mid:ZmrLjJh_Ow6njCZo@root">
      <pre class="moz-quote-pre" wrap="">
</pre>
      <blockquote type="cite">
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">+          "
          run: cmake --build . --parallel --target LuaJIT-test
          working-directory: ${{ env.BUILDDIR }}
</pre>
        </blockquote>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
</pre>
    </blockquote>
  </body>
  <lt-container></lt-container>
</html>