<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Hi, Sergey</p>
<p>thanks for the answers.<br>
</p>
<div class="moz-cite-prefix">On 13.06.2024 13:31, Sergey Kaplun
wrote:<br>
</div>
<p><snipped><br>
</p>
<blockquote type="cite" cite="mid:ZmrKfnnRy9rBYiN3@root"><span
style="white-space: pre-wrap">+test:skipcond({</span>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+ -- luacheck: no global
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I made a patch that remove inline suppressions [1].
I propose to merge it and remove inline suppressions in your patch
series too.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Ok, I'll remove these supressions after merging your patch and rebasing
to the master.
</pre>
</blockquote>
Okay!<br>
<blockquote type="cite" cite="mid:ZmrKfnnRy9rBYiN3@root">
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
+-- We only need the abort reason in the test.
+jparse.start('t')
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Same comment as in previous mail - let's add a comment regarding 't'.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
See my answers here [1].</pre>
</blockquote>
Okay!<br>
<blockquote type="cite" cite="mid:ZmrKfnnRy9rBYiN3@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+
-- XXX: Update hotcounts to avoid hash collisions.
jit.opt.start('hotloop=1')
-
jit.on()
mockalloc.mock()
@@ -49,6 +58,28 @@ tracef()
mockalloc.unmock()
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Same comment as in previous mail - let's avoid name 'mock' here.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
But we actually mock the allocator here, don't we?
Thus, I renamed the new allocated function to avoid confusion.
If you insist, please suggest the correct name instead `mock` |
`unmock`.
</pre>
</blockquote>
<p>We can replace "mock"/"unmock" to "{enable, disable} error
injection".</p>
<p>Actually, I don't want to insist. I'm ok if it wouldn't confuse
anyone.<br>
</p>
<blockquote type="cite" cite="mid:ZmrKfnnRy9rBYiN3@root">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> test:done(true)
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
[1]: <a class="moz-txt-link-freetext" href="https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029218.html">https://lists.tarantool.org/pipermail/tarantool-patches/2024-June/029218.html</a>
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>