<!DOCTYPE html>
<html data-lt-installed="true">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body style="padding-bottom: 1px;">
<p>Sergey,</p>
<p><br>
</p>
<p>thanks for comments.</p>
<p>Updated patch force-pushed.</p>
<p><br>
</p>
<p>Sergey<br>
</p>
<div class="moz-cite-prefix">On 10.06.2024 12:41, Sergey Kaplun
wrote:<br>
</div>
<blockquote type="cite" cite="mid:ZmbKMY1aJUS61Z4y@root">
<pre class="moz-quote-pre" wrap="">Hi, Sergey!
Thanks for the patch!
LGTM, after fixing my comment below.
On 06.06.24, Sergey Bronnikov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">From: Sergey Bronnikov <a class="moz-txt-link-rfc2396E" href="mailto:sergeyb@tarantool.org"><sergeyb@tarantool.org></a>
The patch defines _TARANTOOL as a global in luacheck configuration
file and removes inline suppressions in test files.
---
Branch: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/luajit/tree/ligurio/fix-_TARANTOOL">https://github.com/tarantool/luajit/tree/ligurio/fix-_TARANTOOL</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> 12 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/.luacheckrc b/.luacheckrc
index a32012ca..62ceeaa2 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -1,7 +1,7 @@
-- Use the default LuaJIT globals.
std = 'luajit'
-- This fork also introduces a new global for misc API namespace.
-read_globals = { 'misc' }
+read_globals = { 'misc', '_TARANTOOL' }
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Can we use it only for <tarantool-tests> directory to avoid it appearing
in the Lua sources inside the repository?</pre>
</blockquote>
<p>Sure.</p>
<p>I've updated your patch a bit (formatting):</p>
<p><br>
</p>
<p>--- a/.luacheckrc<br>
+++ b/.luacheckrc<br>
@@ -3,6 +3,12 @@ std = 'luajit'<br>
-- This fork also introduces a new global for misc API namespace.<br>
read_globals = { 'misc', '_TARANTOOL' }<br>
<br>
+-- The `_TARANTOOL` global is often used for skip condition<br>
+-- checks in tests.<br>
+files['test/tarantool-tests/'] = {<br>
+ read_globals = {'_TARANTOOL'}<br>
+}<br>
+<br>
-- These files are inherited from the vanilla LuaJIT or different<br>
-- test suites and need to be coherent with the upstream.<br>
exclude_files = {</p>
<p><br>
</p>
<blockquote type="cite" cite="mid:ZmbKMY1aJUS61Z4y@root">
<pre class="moz-quote-pre" wrap="">
===================================================================
diff --git a/.luacheckrc b/.luacheckrc
index a32012ca..7b5634a5 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -3,6 +3,10 @@ std = 'luajit'
-- This fork also introduces a new global for misc API namespace.
read_globals = { 'misc' }
+-- The `_TARANTOOL` global is often used for skip condition
+-- checks.
+files['test/tarantool-tests/'] = {read_globals = {'_TARANTOOL'}}
+
-- These files are inherited from the vanilla LuaJIT or different
-- test suites and need to be coherent with the upstream.
exclude_files = {
===================================================================
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
-- These files are inherited from the vanilla LuaJIT or different
-- test suites and need to be coherent with the upstream.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
<snipped>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">--
2.34.1
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
<lt-container></lt-container>
</html>