<div>Hi, Igor</div><div> </div><div>thanks for a long-awaited review!</div><div>I'm fine with your proposed changes.</div><div> </div><div>08.02.2024, 19:02, "Igor Munkin" <imun@tarantool.org>:</div><blockquote><p>Sergey,<br /><br />Thanks for the fixes! I've made several touches here[1] and there[2][3]<br />to make the patch LGTM.<br /><br />[1]: <a href="https://github.com/tarantool/luajit/commit/bf239af" rel="noopener noreferrer">https://github.com/tarantool/luajit/commit/bf239af</a><br />[2]: <a href="https://github.com/tarantool/luajit/commit/aa17343" rel="noopener noreferrer">https://github.com/tarantool/luajit/commit/aa17343</a><br />[3]: <a href="https://github.com/tarantool/luajit/commit/ee2f6ce" rel="noopener noreferrer">https://github.com/tarantool/luajit/commit/ee2f6ce</a><br /><br />On 20.10.23, Sergey Bronnikov wrote:</p><blockquote> From: Sergey Bronnikov <<a href="mailto:sergeyb@tarantool.org" rel="noopener noreferrer">sergeyb@tarantool.org</a>><br /> <br /> Epic: <a href="https://github.com/tarantool/tarantool/pull/9145" rel="noopener noreferrer">https://github.com/tarantool/tarantool/pull/9145</a><br /> PR: <a href="https://github.com/tarantool/tarantool/pull/8913" rel="noopener noreferrer">https://github.com/tarantool/tarantool/pull/8913</a><br /> Related issue: <a href="https://github.com/LuaJIT/LuaJIT/issues/549" rel="noopener noreferrer">https://github.com/LuaJIT/LuaJIT/issues/549</a><br /> Branch: <a href="https://github.com/tarantool/luajit/tree/ligurio/lj-549-fix-embedded-bytecode-loader" rel="noopener noreferrer">https://github.com/tarantool/luajit/tree/ligurio/lj-549-fix-embedded-bytecode-loader</a><br /> Patches v1: <a href="https://lists.tarantool.org/tarantool-patches/cover.1690300762.git.sergeyb@tarantool.org/" rel="noopener noreferrer">https://lists.tarantool.org/tarantool-patches/cover.1690300762.git.sergeyb@tarantool.org/</a><br /> Patches v2: <a href="https://lists.tarantool.org/tarantool-patches/cover.1693480177.git.sergeyb@tarantool.org/T/#t" rel="noopener noreferrer">https://lists.tarantool.org/tarantool-patches/cover.1693480177.git.sergeyb@tarantool.org/T/#t</a><br /> <br /> Changes v3:<br /> - removed fio helpers<br /> - build shared library by CMake<br /> <br /> Changes v2:<br /> - added a Lua test that reproduces a problem like reproducer do<br /> - added fixes according to comments from Maxim K. and Sergey K.<br /> <br /> Mike Pall (2):<br />   Fix embedded bytecode loader.<br />   Followup fix for embedded bytecode loader.<br /> <br />  src/lib_package.c | 4 +-<br />  src/lj_bcread.c | 10 +-<br />  src/lj_lex.c | 7 ++<br />  src/lj_lex.h | 1 +<br />  test/tarantool-c-tests/lj-549-lua-load.test.c | 111 ++++++++++++++++++<br />  test/tarantool-tests/CMakeLists.txt | 1 +<br />  .../lj-549-bytecode-loader.test.lua | 27 +++++<br />  .../lj-549-bytecode-loader/CMakeLists.txt | 20 ++++<br />  .../lj-549-bytecode-loader/script.lua | 3 +<br />  9 files changed, 177 insertions(+), 7 deletions(-)<br />  create mode 100644 test/tarantool-c-tests/lj-549-lua-load.test.c<br />  create mode 100644 test/tarantool-tests/lj-549-bytecode-loader.test.lua<br />  create mode 100644 test/tarantool-tests/lj-549-bytecode-loader/CMakeLists.txt<br />  create mode 100644 test/tarantool-tests/lj-549-bytecode-loader/script.lua<br /> <br /> --<br /> 2.34.1<br /> </blockquote><p> </p>--<br />Best regards,<br />IM</blockquote>