<HTML><BODY><div>Hi!</div><div>Thanks for the review!</div><div>Fixed your comments, branch is force-pushed, here is the diff:</div><div> </div><div><div><div>diff --git a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c</div><div>index dbfe17db..82f64f01 100644</div><div>--- a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c</div><div>+++ b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c</div><div>@@ -1,7 +1,8 @@</div><div> #include "lua.h"</div><div> #include "lauxlib.h"</div><div> </div><div>-static int allocate_userdata(lua_State *L) {</div><div>+static int allocate_userdata(lua_State *L)</div><div>+{</div><div> lua_newuserdata(L, 1);</div><div> return 1;</div><div> }</div><div>@@ -11,7 +12,8 @@ static const struct luaL_Reg testoomframe[] = {</div><div> {NULL, NULL}</div><div> };</div><div> </div><div>-LUA_API int luaopen_testoomframe(lua_State *L) {</div><div>+LUA_API int luaopen_testoomframe(lua_State *L)</div><div>+{</div><div> luaL_register(L, "testoomframe", testoomframe);</div><div> return 1;</div><div> }</div></div></div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 11 сентября 2023, 11:09 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16944197530803664670_BODY">Hi, Maxim!<br>Thanks for the patch!<br>LGTM, just two minor nits below.<br><br>On 05.09.23, Maxim Kokryashkin wrote:<br>> Reported by ruidong007.<br><br><snipped><br><br>> diff --git a/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c<br>> new file mode 100644<br>> index 00000000..a54eac63<br>> --- /dev/null<br>> +++ b/test/tarantool-tests/lj-1004-oom-error-frame/testoomframe.c<br>> @@ -0,0 +1,17 @@<br>> +#include <lua.h><br>> +#include <lauxlib.h><br>> +<br>> +static int allocate_userdata(lua_State *L) {<br><br>Nit: Please, start function's block from the new line, i.e:<br><br>| {<br>| lua_newuserdata(L, 1);<br>| return 1;<br>| }<br><br>> + lua_newuserdata(L, 1);<br>> + return 1;<br>> +}<br>> +<br>> +static const struct luaL_Reg testoomframe[] = {<br>> + {"allocate_userdata", allocate_userdata},<br>> + {NULL, NULL}<br>> +};<br>> +<br>> +LUA_API int luaopen_testoomframe(lua_State *L) {<br><br>Ditto.<br><br>> + luaL_register(L, "testoomframe", testoomframe);<br>> + return 1;<br>> +}<br>> --<br>> 2.41.0<br>><br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></BODY></HTML>