<HTML><BODY><div>Hi, Sergey!</div><div>Thanks for the fixes!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16915227730337307572_BODY">Sergey,<br><br><br>On 8/8/23 13:47, Sergey Kaplun wrote:<br><br><br><snipped><br> <div class="mail-quote-collapse">>><br>>> diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml<br>>> index 78abf2e1..13ea6c5b 100644<br>>> --- a/.github/workflows/coverage.yml<br>>> +++ b/.github/workflows/coverage.yml<br>>> @@ -50,8 +50,10 @@ jobs:<br>>> - name: build<br>>> run: cmake --build . --parallel<br>>> working-directory: ${{ env.BUILDDIR }}<br>>> - - name: test and generate code coverage report<br>>> - run: cmake --build ${{ env.BUILDDIR }} --parallel --target coverage<br>>> + - name: run regression tests<br>>> + run: cmake --build ${{ env.BUILDDIR }} --parallel --target test<br>> I suppose it should be LuaJIT-test, since we don't want to run linters<br>> here. See also [1].<br>><br>></div><snipped><br><br>Fixed, thanks!<br><br><br>--- a/.github/workflows/coverage.yml<br>+++ b/.github/workflows/coverage.yml<br>@@ -51,7 +51,7 @@ jobs:<br> run: cmake --build . --parallel<br> working-directory: ${{ env.BUILDDIR }}<br> - name: run regression tests<br>- run: cmake --build ${{ env.BUILDDIR }} --parallel --target test<br>+ run: cmake --build ${{ env.BUILDDIR }} --parallel --target<br>LuaJIT-test<br> - name: generate code coverage report<br> run: cmake --build ${{ env.BUILDDIR }} --parallel --target<br>LuaJIT-coverage<br> - name: send code coverage to coveralls.io</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>