<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16910486401758982824_BODY">Fixed 208 occurrences of E251 ("unexpected spaces around keyword /<br>parameter equals") error reported by pycodestyle[1].<br><br>[1]: <a href="https://www.flake8rules.com/rules/E251.html" target="_blank">https://www.flake8rules.com/rules/E251.html</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> src/luajit-gdb.py | 102 ++++++++++++++++++++++----------------------<br> src/luajit_lldb.py | 104 ++++++++++++++++++++++-----------------------<br> 2 files changed, 103 insertions(+), 103 deletions(-)<br><br>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py<br>index 09899f58..f87063f8 100644<br>--- a/src/luajit-gdb.py<br>+++ b/src/luajit-gdb.py<br>@@ -347,8 +347,8 @@ def dump_lj_tlightud(tv):<br> <br> def dump_lj_tstr(tv):<br> return 'string {body} @ {address}'.format(<br>- body = strdata(gcval(tv['gcr'])),<br>- address = strx64(gcval(tv['gcr']))<br>+ body=strdata(gcval(tv['gcr'])),<br>+ address=strx64(gcval(tv['gcr']))<br> )<br> <br> def dump_lj_tupval(tv):<br>@@ -367,10 +367,10 @@ def dump_lj_tfunc(tv):<br> if ffid == 0:<br> pt = funcproto(func)<br> return 'Lua function @ {addr}, {nupvals} upvalues, {chunk}:{line}'.format(<br>- addr = strx64(func),<br>- nupvals = int(func['nupvalues']),<br>- chunk = strdata(cast('GCstr *', gcval(pt['chunkname']))),<br>- line = pt['firstline']<br>+ addr=strx64(func),<br>+ nupvals=int(func['nupvalues']),<br>+ chunk=strdata(cast('GCstr *', gcval(pt['chunkname']))),<br>+ line=pt['firstline']<br> )<br> elif ffid == 1:<br> return 'C function @ {}'.format(strx64(func['f']))<br>@@ -380,8 +380,8 @@ def dump_lj_tfunc(tv):<br> def dump_lj_ttrace(tv):<br> trace = cast('struct GCtrace *', gcval(tv['gcr']))<br> return 'trace {traceno} @ {addr}'.format(<br>- traceno = strx64(trace['traceno']),<br>- addr = strx64(trace)<br>+ traceno=strx64(trace['traceno']),<br>+ addr=strx64(trace)<br> )<br> <br> def dump_lj_tcdata(tv):<br>@@ -390,9 +390,9 @@ def dump_lj_tcdata(tv):<br> def dump_lj_ttab(tv):<br> table = cast('GCtab *', gcval(tv['gcr']))<br> return 'table @ {gcr} (asize: {asize}, hmask: {hmask})'.format(<br>- gcr = strx64(table),<br>- asize = table['asize'],<br>- hmask = strx64(table['hmask']),<br>+ gcr=strx64(table),<br>+ asize=table['asize'],<br>+ hmask=strx64(table['hmask']),<br> )<br> <br> def dump_lj_tudata(tv):<br>@@ -436,16 +436,16 @@ def dump_framelink_slot_address(fr):<br> def dump_framelink(L, fr):<br> if fr == frame_sentinel(L):<br> return '{addr} [S ] FRAME: dummy L'.format(<br>- addr = dump_framelink_slot_address(fr),<br>+ addr=dump_framelink_slot_address(fr),<br> )<br> return '{addr} [ ] FRAME: [{pp}] delta={d}, {f}'.format(<br>- addr = dump_framelink_slot_address(fr),<br>- pp = 'PP' if frame_ispcall(fr) else '{frname}{p}'.format(<br>- frname = frametypes(int(frame_type(fr))),<br>- p = 'P' if frame_typep(fr) & FRAME_P else ''<br>+ addr=dump_framelink_slot_address(fr),<br>+ pp='PP' if frame_ispcall(fr) else '{frname}{p}'.format(<br>+ frname=frametypes(int(frame_type(fr))),<br>+ p='P' if frame_typep(fr) & FRAME_P else ''<br> ),<br>- d = cast('TValue *', fr) - cast('TValue *', frame_prev(fr)),<br>- f = dump_lj_tfunc(fr - LJ_FR2),<br>+ d=cast('TValue *', fr) - cast('TValue *', frame_prev(fr)),<br>+ f=dump_lj_tfunc(fr - LJ_FR2),<br> )<br> <br> def dump_stack_slot(L, slot, base=None, top=None):<br>@@ -453,12 +453,12 @@ def dump_stack_slot(L, slot, base=None, top=None):<br> top = top or L['top']<br> <br> return '{addr}{padding} [ {B}{T}{M}] VALUE: {value}'.format(<br>- addr = strx64(slot),<br>- padding = PADDING,<br>- B = 'B' if slot == base else ' ',<br>- T = 'T' if slot == top else ' ',<br>- M = 'M' if slot == mref('TValue *', L['maxstack']) else ' ',<br>- value = dump_tvalue(slot),<br>+ addr=strx64(slot),<br>+ padding=PADDING,<br>+ B='B' if slot == base else ' ',<br>+ T='T' if slot == top else ' ',<br>+ M='M' if slot == mref('TValue *', L['maxstack']) else ' ',<br>+ value=dump_tvalue(slot),<br> )<br> <br> def dump_stack(L, base=None, top=None):<br>@@ -470,8 +470,8 @@ def dump_stack(L, base=None, top=None):<br> <br> dump = [<br> '{padding} Red zone: {nredslots: >2} slots {padding}'.format(<br>- padding = '-' * len(PADDING),<br>- nredslots = red,<br>+ padding='-' * len(PADDING),<br>+ nredslots=red,<br> ),<br> ]<br> dump.extend([<br>@@ -480,14 +480,14 @@ def dump_stack(L, base=None, top=None):<br> ])<br> dump.extend([<br> '{padding} Stack: {nstackslots: >5} slots {padding}'.format(<br>- padding = '-' * len(PADDING),<br>- nstackslots = int((tou64(maxstack) - tou64(stack)) >> 3),<br>+ padding='-' * len(PADDING),<br>+ nstackslots=int((tou64(maxstack) - tou64(stack)) >> 3),<br> ),<br> dump_stack_slot(L, maxstack, base, top),<br> '{start}:{end} [ ] {nfreeslots} slots: Free stack slots'.format(<br>- start = strx64(top + 1),<br>- end = strx64(maxstack - 1),<br>- nfreeslots = int((tou64(maxstack) - tou64(top) - 8) >> 3),<br>+ start=strx64(top + 1),<br>+ end=strx64(maxstack - 1),<br>+ nfreeslots=int((tou64(maxstack) - tou64(top) - 8) >> 3),<br> ),<br> ])<br> <br>@@ -504,19 +504,19 @@ def dump_stack(L, base=None, top=None):<br> <br> def dump_gc(g):<br> gc = g['gc']<br>- stats = ['{key}: {value}'.format(key = f, value = gc[f]) for f in (<br>+ stats = ['{key}: {value}'.format(key=f, value=gc[f]) for f in (<br> 'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'<br> )]<br> <br> stats += ['sweepstr: {sweepstr}/{strmask}'.format(<br>- sweepstr = gc['sweepstr'],<br>+ sweepstr=gc['sweepstr'],<br> # String hash mask (size of hash table - 1).<br>- strmask = g['strmask'] + 1,<br>+ strmask=g['strmask'] + 1,<br> )]<br> <br> stats += ['{key}: {number} objects'.format(<br>- key = stat,<br>- number = handler(gc[stat])<br>+ key=stat,<br>+ number=handler(gc[stat])<br> ) for stat, handler in gclen.items()]<br> <br> return '\n'.join(map(lambda s: '\t' + s, stats))<br>@@ -543,9 +543,9 @@ pointers respectively.<br> gdb.write(<br> 'LJ_64: {LJ_64}, LJ_GC64: {LJ_GC64}, LJ_DUALNUM: {LJ_DUALNUM}\n'<br> .format(<br>- LJ_64 = LJ_64,<br>- LJ_GC64 = LJ_GC64,<br>- LJ_DUALNUM = LJ_DUALNUM<br>+ LJ_64=LJ_64,<br>+ LJ_GC64=LJ_GC64,<br>+ LJ_DUALNUM=LJ_DUALNUM<br> )<br> )<br> <br>@@ -596,9 +596,9 @@ is replaced with the corresponding error when decoding fails.<br> def invoke(self, arg, from_tty):<br> string = cast('GCstr *', parse_arg(arg))<br> gdb.write("String: {body} [{len} bytes] with hash {hash}\n".format(<br>- body = strdata(string),<br>- hash = strx64(string['hash']),<br>- len = string['len'],<br>+ body=strdata(string),<br>+ hash=strx64(string['hash']),<br>+ len=string['len'],<br> ))<br> <br> class LJDumpTable(LJBase):<br>@@ -630,9 +630,9 @@ The command receives a GCtab adress and dumps the table contents:<br> for i in range(capacity['apart']):<br> slot = array + i<br> gdb.write('{ptr}: [{index}]: {value}\n'.format(<br>- ptr = slot,<br>- index = i,<br>- value = dump_tvalue(slot)<br>+ ptr=slot,<br>+ index=i,<br>+ value=dump_tvalue(slot)<br> ))<br> <br> gdb.write('Hash part: {} nodes\n'.format(capacity['hpart']))<br>@@ -640,10 +640,10 @@ The command receives a GCtab adress and dumps the table contents:<br> for i in range(capacity['hpart']):<br> node = nodes + i<br> gdb.write('{ptr}: {{ {key} }} => {{ {val} }}; next = {n}\n'.format(<br>- ptr = node,<br>- key = dump_tvalue(node['key']),<br>- val= dump_tvalue(node['val']),<br>- n = mref('struct Node *', node['next'])<br>+ ptr=node,<br>+ key=dump_tvalue(node['key']),<br>+ val=dump_tvalue(node['val']),<br>+ n=mref('struct Node *', node['next'])<br> ))<br> <br> class LJDumpStack(LJBase):<br>@@ -723,8 +723,8 @@ The command requires no args and dumps current GC stats:<br> def invoke(self, arg, from_tty):<br> g = G(L(None))<br> gdb.write('GC stats: {state}\n{stats}\n'.format(<br>- state = gc_state(g),<br>- stats = dump_gc(g)<br>+ state=gc_state(g),<br>+ stats=dump_gc(g)<br> ))<br> <br> def init(commands):<br>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py<br>index a7a756e9..f502a0e6 100644<br>--- a/src/luajit_lldb.py<br>+++ b/src/luajit_lldb.py<br>@@ -390,19 +390,19 @@ gclen = {<br> <br> def dump_gc(g):<br> gc = g.gc<br>- stats = ['{key}: {value}'.format(key = f, value = getattr(gc, f)) for f in (<br>+ stats = ['{key}: {value}'.format(key=f, value=getattr(gc, f)) for f in (<br> 'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'<br> )]<br> <br> stats += ['sweepstr: {sweepstr}/{strmask}'.format(<br>- sweepstr = gc.sweepstr,<br>+ sweepstr=gc.sweepstr,<br> # String hash mask (size of hash table - 1).<br>- strmask = g.strmask + 1,<br>+ strmask=g.strmask + 1,<br> )]<br> <br> stats += ['{key}: {number} objects'.format(<br>- key = stat,<br>- number = handler(getattr(gc, stat))<br>+ key=stat,<br>+ number=handler(getattr(gc, stat))<br> ) for stat, handler in gclen.items()]<br> return '\n'.join(map(lambda s: '\t' + s, stats))<br> <br>@@ -521,8 +521,8 @@ def dump_lj_tlightud(tv):<br> <br> def dump_lj_tstr(tv):<br> return 'string {body} @ {address}'.format(<br>- body = strdata(cast(GCstrPtr, gcval(tv.gcr))),<br>- address = strx64(gcval(tv.gcr))<br>+ body=strdata(cast(GCstrPtr, gcval(tv.gcr))),<br>+ address=strx64(gcval(tv.gcr))<br> )<br> <br> def dump_lj_tupval(tv):<br>@@ -541,10 +541,10 @@ def dump_lj_tfunc(tv):<br> if ffid == 0:<br> pt = funcproto(func)<br> return 'Lua function @ {addr}, {nupvals} upvalues, {chunk}:{line}'.format(<br>- addr = strx64(func),<br>- nupvals = func.nupvalues,<br>- chunk = strdata(cast(GCstrPtr, gcval(pt.chunkname))),<br>- line = pt.firstline<br>+ addr=strx64(func),<br>+ nupvals=func.nupvalues,<br>+ chunk=strdata(cast(GCstrPtr, gcval(pt.chunkname))),<br>+ line=pt.firstline<br> )<br> elif ffid == 1:<br> return 'C function @ {}'.format(strx64(func.f))<br>@@ -554,8 +554,8 @@ def dump_lj_tfunc(tv):<br> def dump_lj_ttrace(tv):<br> trace = cast(GCtracePtr, gcval(tv.gcr))<br> return 'trace {traceno} @ {addr}'.format(<br>- traceno = strx64(trace.traceno),<br>- addr = strx64(trace)<br>+ traceno=strx64(trace.traceno),<br>+ addr=strx64(trace)<br> )<br> <br> def dump_lj_tcdata(tv):<br>@@ -564,9 +564,9 @@ def dump_lj_tcdata(tv):<br> def dump_lj_ttab(tv):<br> table = cast(GCtabPtr, gcval(tv.gcr))<br> return 'table @ {gcr} (asize: {asize}, hmask: {hmask})'.format(<br>- gcr = strx64(table),<br>- asize = table.asize,<br>- hmask = strx64(table.hmask),<br>+ gcr=strx64(table),<br>+ asize=table.asize,<br>+ hmask=strx64(table.hmask),<br> )<br> <br> def dump_lj_tudata(tv):<br>@@ -724,16 +724,16 @@ def dump_framelink_slot_address(fr):<br> def dump_framelink(L, fr):<br> if fr == frame_sentinel(L):<br> return '{addr} [S ] FRAME: dummy L'.format(<br>- addr = dump_framelink_slot_address(fr),<br>+ addr=dump_framelink_slot_address(fr),<br> )<br> return '{addr} [ ] FRAME: [{pp}] delta={d}, {f}'.format(<br>- addr = dump_framelink_slot_address(fr),<br>- pp = 'PP' if frame_ispcall(fr) else '{frname}{p}'.format(<br>- frname = frametypes(int(frame_type(fr))),<br>- p = 'P' if frame_typep(fr) & FRAME_P else ''<br>+ addr=dump_framelink_slot_address(fr),<br>+ pp='PP' if frame_ispcall(fr) else '{frname}{p}'.format(<br>+ frname=frametypes(int(frame_type(fr))),<br>+ p='P' if frame_typep(fr) & FRAME_P else ''<br> ),<br>- d = fr - frame_prev(fr),<br>- f = dump_lj_tfunc(fr - LJ_FR2),<br>+ d=fr - frame_prev(fr),<br>+ f=dump_lj_tfunc(fr - LJ_FR2),<br> )<br> <br> def dump_stack_slot(L, slot, base=None, top=None):<br>@@ -741,12 +741,12 @@ def dump_stack_slot(L, slot, base=None, top=None):<br> top = top or L.top<br> <br> return '{addr:{padding}} [ {B}{T}{M}] VALUE: {value}'.format(<br>- addr = strx64(slot),<br>- padding = 2 * len(PADDING) + 1,<br>- B = 'B' if slot == base else ' ',<br>- T = 'T' if slot == top else ' ',<br>- M = 'M' if slot == mref(TValuePtr, L.maxstack) else ' ',<br>- value = dump_tvalue(slot),<br>+ addr=strx64(slot),<br>+ padding=2 * len(PADDING) + 1,<br>+ B='B' if slot == base else ' ',<br>+ T='T' if slot == top else ' ',<br>+ M='M' if slot == mref(TValuePtr, L.maxstack) else ' ',<br>+ value=dump_tvalue(slot),<br> )<br> <br> def dump_stack(L, base=None, top=None):<br>@@ -758,8 +758,8 @@ def dump_stack(L, base=None, top=None):<br> <br> dump = [<br> '{padding} Red zone: {nredslots: >2} slots {padding}'.format(<br>- padding = '-' * len(PADDING),<br>- nredslots = red,<br>+ padding='-' * len(PADDING),<br>+ nredslots=red,<br> ),<br> ]<br> dump.extend([<br>@@ -768,15 +768,15 @@ def dump_stack(L, base=None, top=None):<br> ])<br> dump.extend([<br> '{padding} Stack: {nstackslots: >5} slots {padding}'.format(<br>- padding = '-' * len(PADDING),<br>- nstackslots = int((maxstack - stack) >> 3),<br>+ padding='-' * len(PADDING),<br>+ nstackslots=int((maxstack - stack) >> 3),<br> ),<br> dump_stack_slot(L, maxstack, base, top),<br> '{start:{padding}}:{end:{padding}} [ ] {nfreeslots} slots: Free stack slots'.format(<br>- start = strx64(top + 1),<br>- end = strx64(maxstack - 1),<br>- padding = len(PADDING),<br>- nfreeslots = int((maxstack - top - 8) >> 3),<br>+ start=strx64(top + 1),<br>+ end=strx64(maxstack - 1),<br>+ padding=len(PADDING),<br>+ nfreeslots=int((maxstack - top - 8) >> 3),<br> ),<br> ])<br> <br>@@ -856,9 +856,9 @@ pointers respectively.<br> print(<br> 'LJ_64: {LJ_64}, LJ_GC64: {LJ_GC64}, LJ_DUALNUM: {LJ_DUALNUM}'<br> .format(<br>- LJ_64 = LJ_64,<br>- LJ_GC64 = LJ_GC64,<br>- LJ_DUALNUM = LJ_DUALNUM<br>+ LJ_64=LJ_64,<br>+ LJ_GC64=LJ_GC64,<br>+ LJ_DUALNUM=LJ_DUALNUM<br> )<br> )<br> <br>@@ -883,8 +883,8 @@ The command requires no args and dumps current GC stats:<br> def execute(self, debugger, args, result):<br> g = G(L(None))<br> print('GC stats: {state}\n{stats}'.format(<br>- state = gc_state(g),<br>- stats = dump_gc(g)<br>+ state=gc_state(g),<br>+ stats=dump_gc(g)<br> ))<br> <br> class LJDumpString(Command):<br>@@ -900,9 +900,9 @@ is replaced with the corresponding error when decoding fails.<br> def execute(self, debugger, args, result):<br> string_ptr = GCstrPtr(cast('GCstr *', self.parse(args)))<br> print("String: {body} [{len} bytes] with hash {hash}".format(<br>- body = strdata(string_ptr),<br>- hash = strx64(string_ptr.hash),<br>- len = string_ptr.len,<br>+ body=strdata(string_ptr),<br>+ hash=strx64(string_ptr.hash),<br>+ len=string_ptr.len,<br> ))<br> <br> class LJDumpTable(Command):<br>@@ -933,9 +933,9 @@ The command receives a GCtab adress and dumps the table contents:<br> for i in range(capacity['apart']):<br> slot = array + i<br> print('{ptr}: [{index}]: {value}'.format(<br>- ptr = strx64(slot),<br>- index = i,<br>- value = dump_tvalue(slot)<br>+ ptr=strx64(slot),<br>+ index=i,<br>+ value=dump_tvalue(slot)<br> ))<br> <br> print('Hash part: {} nodes'.format(capacity['hpart']))<br>@@ -943,10 +943,10 @@ The command receives a GCtab adress and dumps the table contents:<br> for i in range(capacity['hpart']):<br> node = nodes + i<br> print('{ptr}: {{ {key} }} => {{ {val} }}; next = {n}'.format(<br>- ptr = strx64(node),<br>- key = dump_tvalue(TValuePtr(node.key.addr)),<br>- val= dump_tvalue(TValuePtr(node.val.addr)),<br>- n = strx64(mref(NodePtr, node.next))<br>+ ptr=strx64(node),<br>+ key=dump_tvalue(TValuePtr(node.key.addr)),<br>+ val=dump_tvalue(TValuePtr(node.val.addr)),<br>+ n=strx64(mref(NodePtr, node.next))<br> ))<br> <br> class LJDumpStack(Command):<br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>