<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16910486531777642430_BODY">Fixed 4 occurrences of E722 ("do not use bare 'except'") error reported<br>by pycodestyle[1]. Since no particular exception type should be handled,<br>the base Exception class is chosen.<br><br>[1]: <a href="https://www.flake8rules.com/rules/E722.html" target="_blank">https://www.flake8rules.com/rules/E722.html</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> src/luajit-gdb.py | 6 +++---<br> src/luajit_lldb.py | 2 +-<br> 2 files changed, 4 insertions(+), 4 deletions(-)<br><br>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py<br>index 8e786528..a0c8f24e 100644<br>--- a/src/luajit-gdb.py<br>+++ b/src/luajit-gdb.py<br>@@ -838,14 +838,14 @@ def init(commands):<br> # Try to remove the callback at first to not append duplicates to<br> # gdb.events.new_objfile internal list.<br> disconnect(load)<br>- except:<br>+ except Exception:<br> # Callback is not connected.<br> pass<br> <br> try:<br> # Detect whether libluajit objfile is loaded.<br> gdb.parse_and_eval('luaJIT_setmode')<br>- except:<br>+ except Exception:<br> gdb.write('luajit-gdb.py initialization is postponed '<br> 'until libluajit objfile is loaded\n')<br> # Add a callback to be executed when the next objfile is loaded.<br>@@ -856,7 +856,7 @@ def init(commands):<br> LJ_64 = str(gdb.parse_and_eval('IRT_PTR')) == 'IRT_P64'<br> LJ_FR2 = LJ_GC64 = str(gdb.parse_and_eval('IRT_PGC')) == 'IRT_P64'<br> LJ_DUALNUM = gdb.lookup_global_symbol('lj_lib_checknumber') is not None<br>- except:<br>+ except Exception:<br> gdb.write('luajit-gdb.py failed to load: '<br> 'no debugging symbols found for libluajit\n')<br> return<br>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py<br>index e481cfa0..4787c62c 100644<br>--- a/src/luajit_lldb.py<br>+++ b/src/luajit_lldb.py<br>@@ -1096,7 +1096,7 @@ def configure(debugger):<br> LJ_64 = member.unsigned & 0x1f == IRT_P64<br> if member.name == 'IRT_PGC':<br> LJ_FR2 = LJ_GC64 = member.unsigned & 0x1f == IRT_P64<br>- except:<br>+ except Exception:<br> print('luajit_lldb.py failed to load: '<br> 'no debugging symbols found for libluajit')<br> return<br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>