<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16910486360986858655_BODY">Fixed the only occurrence of E202 ("whitespace before ')'"), 7<br>occurrences of E201 ("whitespace after '['") and 7 occurrences of E202<br>("whitespace before ']'") errors reported by pycodestyle[1][2].<br><br>[1]: <a href="https://www.flake8rules.com/rules/E201.html" target="_blank">https://www.flake8rules.com/rules/E201.html</a><br>[2]: <a href="https://www.flake8rules.com/rules/E202.html" target="_blank">https://www.flake8rules.com/rules/E202.html</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> src/luajit-gdb.py | 14 +++++++-------<br> src/luajit_lldb.py | 12 ++++++------<br> 2 files changed, 13 insertions(+), 13 deletions(-)<br><br>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py<br>index b84fdc93..198578b1 100644<br>--- a/src/luajit-gdb.py<br>+++ b/src/luajit-gdb.py<br>@@ -195,7 +195,7 @@ def L(L=None):<br> # lookup a symbol for the main coroutine considering the host app<br> # XXX Fragile: though the loop initialization looks like a crap but it<br> # respects both Python 2 and Python 3.<br>- for l in [ L ] + list(map(lambda l: lookup(l), (<br>+ for l in [L] + list(map(lambda l: lookup(l), (<br> # LuaJIT main coro (see luajit/src/luajit.c)<br> 'globalL',<br> # Tarantool main coro (see tarantool/src/lua/init.h)<br>@@ -504,20 +504,20 @@ def dump_stack(L, base=None, top=None):<br> <br> def dump_gc(g):<br> gc = g['gc']<br>- stats = [ '{key}: {value}'.format(key = f, value = gc[f]) for f in (<br>+ stats = ['{key}: {value}'.format(key = f, value = gc[f]) for f in (<br> 'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'<br>- ) ]<br>+ )]<br> <br>- stats += [ 'sweepstr: {sweepstr}/{strmask}'.format(<br>+ stats += ['sweepstr: {sweepstr}/{strmask}'.format(<br> sweepstr = gc['sweepstr'],<br> # String hash mask (size of hash table - 1).<br> strmask = g['strmask'] + 1,<br>- ) ]<br>+ )]<br> <br>- stats += [ '{key}: {number} objects'.format(<br>+ stats += ['{key}: {number} objects'.format(<br> key = stat,<br> number = handler(gc[stat])<br>- ) for stat, handler in gclen.items() ]<br>+ ) for stat, handler in gclen.items()]<br> <br> return '\n'.join(map(lambda s: '\t' + s, stats))<br> <br>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py<br>index 3f636546..2887723b 100644<br>--- a/src/luajit_lldb.py<br>+++ b/src/luajit_lldb.py<br>@@ -211,7 +211,7 @@ c_structs = {<br> }<br> <br> for cls in c_structs.keys():<br>- globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]} )<br>+ globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]})<br> <br> for cls in Struct.__subclasses__():<br> ptr_name = cls.__name__ + 'Ptr'<br>@@ -394,16 +394,16 @@ def dump_gc(g):<br> 'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'<br> )]<br> <br>- stats += [ 'sweepstr: {sweepstr}/{strmask}'.format(<br>+ stats += ['sweepstr: {sweepstr}/{strmask}'.format(<br> sweepstr = gc.sweepstr,<br> # String hash mask (size of hash table - 1).<br> strmask = g.strmask + 1,<br>- ) ]<br>+ )]<br> <br>- stats += [ '{key}: {number} objects'.format(<br>+ stats += ['{key}: {number} objects'.format(<br> key = stat,<br> number = handler(getattr(gc, stat))<br>- ) for stat, handler in gclen.items() ]<br>+ ) for stat, handler in gclen.items()]<br> return '\n'.join(map(lambda s: '\t' + s, stats))<br> <br> def mref(typename, obj):<br>@@ -424,7 +424,7 @@ def L(L=None):<br> # lookup a symbol for the main coroutine considering the host app<br> # XXX Fragile: though the loop initialization looks like a crap but it<br> # respects both Python 2 and Python 3.<br>- for l in [ L ] + list(map(lambda l: lookup_global(l), (<br>+ for l in [L] + list(map(lambda l: lookup_global(l), (<br> # LuaJIT main coro (see luajit/src/luajit.c)<br> 'globalL',<br> # Tarantool main coro (see tarantool/src/lua/init.h)<br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>