<HTML><BODY><div>Hi, Sergey!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 2 августа 2023, 11:58 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16909666882031092315_BODY">From: Sergey Bronnikov <<a href="/compose?To=sergeyb@tarantool.org">sergeyb@tarantool.org</a>><br><br>Patch adds a GitHub Action, that clones checkpatch repository, and adds<br>a job, that runs checkpatch [1] using CMake target "LuaJIT-checkpatch"<br>against commits on top of the master branch.<br><br>1. <a href="https://github.com/tarantool/checkpatch" target="_blank">https://github.com/tarantool/checkpatch</a><br>---<br> .github/actions/checkpatch/action.yml | 11 +++++++++++<br> .github/workflows/lint.yml | 20 ++++++++++++++++++++<br> 2 files changed, 31 insertions(+)<br> create mode 100644 .github/actions/checkpatch/action.yml<br><br>diff --git a/.github/actions/checkpatch/action.yml b/.github/actions/checkpatch/action.yml<br>new file mode 100644<br>index 00000000..cd2cce62<br>--- /dev/null<br>+++ b/.github/actions/checkpatch/action.yml<br>@@ -0,0 +1,11 @@<br>+name: Setup checkpatch<br>+description: Setup a script for checking for codestyle and grammar errors<br>+runs:<br>+ using: composite<br>+ steps:<br>+ - uses: actions/checkout@v3<br>+ with:<br>+ repository: tarantool/checkpatch<br>+ path: 'checkpatch'<br>+ - run: apt install -y codespell<br>+ shell: bash<br>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml<br>index 8154a622..db3af975 100644<br>--- a/.github/workflows/lint.yml<br>+++ b/.github/workflows/lint.yml<br>@@ -51,3 +51,23 @@ jobs:<br> - name: luacheck<br> run: cmake --build . --target LuaJIT-luacheck<br> working-directory: ${{ env.BUILDDIR }}<br>+<br>+ checkpatch:<br>+ runs-on: [self-hosted, lightweight, Linux, x86_64]<br>+<br>+ steps:<br>+ - uses: actions/checkout@v3<br>+ with:<br>+ fetch-depth: 0<br>+ submodules: recursive<br>+ - name: checkpatch<br>+ uses: ./.github/actions/checkpatch<br>+ - name: environment<br>+ uses: ./.github/actions/setup<br>+ - name: make tarantool/master available<br>+ run: git checkout tarantool/master && git checkout -<br>+ - name: configure<br>+ run: cmake -S . -B ${{ env.BUILDDIR }}<br>+ - name: checkpatch<br>+ run: cmake --build . --target LuaJIT-checkpatch<br>+ working-directory: ${{ env.BUILDDIR }}<br>--<br>2.34.1</div></div></div></div></blockquote><div> </div></BODY></HTML>