<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16910486371772930713_BODY">Fixed 36 occurrences of E203 ("whitespace before ':'") error reported<br>by pycodestyle[1]. Furthermore, many other parts have been re-aligned<br>the similar way to be in sync with the default code style.<br><br>[1]: <a href="https://www.flake8rules.com/rules/E203.html" target="_blank">https://www.flake8rules.com/rules/E203.html</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> src/luajit-gdb.py | 98 +++++++++++++++++++++----------------------<br> src/luajit_lldb.py | 102 ++++++++++++++++++++++-----------------------<br> 2 files changed, 100 insertions(+), 100 deletions(-)<br><br>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py<br>index 198578b1..09899f58 100644<br>--- a/src/luajit-gdb.py<br>+++ b/src/luajit-gdb.py<br>@@ -65,20 +65,20 @@ def strx64(val):<br> # Types {{{<br> <br> LJ_T = {<br>- 'NIL' : i2notu32(0),<br>- 'FALSE' : i2notu32(1),<br>- 'TRUE' : i2notu32(2),<br>- 'LIGHTUD' : i2notu32(3),<br>- 'STR' : i2notu32(4),<br>- 'UPVAL' : i2notu32(5),<br>- 'THREAD' : i2notu32(6),<br>- 'PROTO' : i2notu32(7),<br>- 'FUNC' : i2notu32(8),<br>- 'TRACE' : i2notu32(9),<br>- 'CDATA' : i2notu32(10),<br>- 'TAB' : i2notu32(11),<br>- 'UDATA' : i2notu32(12),<br>- 'NUMX' : i2notu32(13),<br>+ 'NIL': i2notu32(0),<br>+ 'FALSE': i2notu32(1),<br>+ 'TRUE': i2notu32(2),<br>+ 'LIGHTUD': i2notu32(3),<br>+ 'STR': i2notu32(4),<br>+ 'UPVAL': i2notu32(5),<br>+ 'THREAD': i2notu32(6),<br>+ 'PROTO': i2notu32(7),<br>+ 'FUNC': i2notu32(8),<br>+ 'TRACE': i2notu32(9),<br>+ 'CDATA': i2notu32(10),<br>+ 'TAB': i2notu32(11),<br>+ 'UDATA': i2notu32(12),<br>+ 'NUMX': i2notu32(13),<br> }<br> <br> def typenames(value):<br>@@ -95,22 +95,22 @@ FRAME_P = 0x4<br> FRAME_TYPEP = FRAME_TYPE | FRAME_P<br> <br> FRAME = {<br>- 'LUA': 0x0,<br>- 'C': 0x1,<br>- 'CONT': 0x2,<br>- 'VARG': 0x3,<br>- 'LUAP': 0x4,<br>- 'CP': 0x5,<br>- 'PCALL': 0x6,<br>+ 'LUA': 0x0,<br>+ 'C': 0x1,<br>+ 'CONT': 0x2,<br>+ 'VARG': 0x3,<br>+ 'LUAP': 0x4,<br>+ 'CP': 0x5,<br>+ 'PCALL': 0x6,<br> 'PCALLH': 0x7,<br> }<br> <br> def frametypes(ft):<br> return {<br>- FRAME['LUA'] : 'L',<br>- FRAME['C'] : 'C',<br>- FRAME['CONT'] : 'M',<br>- FRAME['VARG'] : 'V',<br>+ FRAME['LUA']: 'L',<br>+ FRAME['C']: 'C',<br>+ FRAME['CONT']: 'M',<br>+ FRAME['VARG']: 'V',<br> }.get(ft, '?')<br> <br> def bc_a(ins):<br>@@ -299,12 +299,12 @@ def gcringlen(root):<br> return 1 + gclistlen(gcnext(root), gcref(root))<br> <br> gclen = {<br>- 'root': gclistlen,<br>- 'gray': gclistlen,<br>+ 'root': gclistlen,<br>+ 'gray': gclistlen,<br> 'grayagain': gclistlen,<br>- 'weak': gclistlen,<br>+ 'weak': gclistlen,<br> # XXX: gc.mmudata is a ring-list.<br>- 'mmudata': gcringlen,<br>+ 'mmudata': gcringlen,<br> }<br> <br> # The generator that implements frame iterator.<br>@@ -410,20 +410,20 @@ def dump_lj_invalid(tv):<br> # }}}<br> <br> dumpers = {<br>- 'LJ_TNIL': dump_lj_tnil,<br>- 'LJ_TFALSE': dump_lj_tfalse,<br>- 'LJ_TTRUE': dump_lj_ttrue,<br>+ 'LJ_TNIL': dump_lj_tnil,<br>+ 'LJ_TFALSE': dump_lj_tfalse,<br>+ 'LJ_TTRUE': dump_lj_ttrue,<br> 'LJ_TLIGHTUD': dump_lj_tlightud,<br>- 'LJ_TSTR': dump_lj_tstr,<br>- 'LJ_TUPVAL': dump_lj_tupval,<br>- 'LJ_TTHREAD': dump_lj_tthread,<br>- 'LJ_TPROTO': dump_lj_tproto,<br>- 'LJ_TFUNC': dump_lj_tfunc,<br>- 'LJ_TTRACE': dump_lj_ttrace,<br>- 'LJ_TCDATA': dump_lj_tcdata,<br>- 'LJ_TTAB': dump_lj_ttab,<br>- 'LJ_TUDATA': dump_lj_tudata,<br>- 'LJ_TNUMX': dump_lj_tnumx,<br>+ 'LJ_TSTR': dump_lj_tstr,<br>+ 'LJ_TUPVAL': dump_lj_tupval,<br>+ 'LJ_TTHREAD': dump_lj_tthread,<br>+ 'LJ_TPROTO': dump_lj_tproto,<br>+ 'LJ_TFUNC': dump_lj_tfunc,<br>+ 'LJ_TTRACE': dump_lj_ttrace,<br>+ 'LJ_TCDATA': dump_lj_tcdata,<br>+ 'LJ_TTAB': dump_lj_ttab,<br>+ 'LJ_TUDATA': dump_lj_tudata,<br>+ 'LJ_TNUMX': dump_lj_tnumx,<br> }<br> <br> def dump_tvalue(tvalue):<br>@@ -695,8 +695,8 @@ The command requires no args and dumps current VM and GC states<br> g = G(L(None))<br> gdb.write('{}\n'.format('\n'.join(<br> map(lambda t: '{} state: {}'.format(*t), {<br>- 'VM': vm_state(g),<br>- 'GC': gc_state(g),<br>+ 'VM': vm_state(g),<br>+ 'GC': gc_state(g),<br> 'JIT': jit_state(g),<br> }.items())<br> )))<br>@@ -785,13 +785,13 @@ def init(commands):<br> <br> def load(event=None):<br> init({<br>- 'lj-arch': LJDumpArch,<br>- 'lj-tv': LJDumpTValue,<br>- 'lj-str': LJDumpString,<br>- 'lj-tab': LJDumpTable,<br>+ 'lj-arch': LJDumpArch,<br>+ 'lj-tv': LJDumpTValue,<br>+ 'lj-str': LJDumpString,<br>+ 'lj-tab': LJDumpTable,<br> 'lj-stack': LJDumpStack,<br> 'lj-state': LJState,<br>- 'lj-gc': LJGC,<br>+ 'lj-gc': LJGC,<br> })<br> <br> load(None)<br>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py<br>index 2887723b..b9c8a0b9 100644<br>--- a/src/luajit_lldb.py<br>+++ b/src/luajit_lldb.py<br>@@ -88,8 +88,8 @@ class MetaStruct(type):<br> <br> def make_general(field, tp):<br> builtin = {<br>- 'uint': 'unsigned',<br>- 'int': 'signed',<br>+ 'uint': 'unsigned',<br>+ 'int': 'signed',<br> 'string': 'value',<br> }<br> if tp in builtin.keys():<br>@@ -380,12 +380,12 @@ def gcringlen(root):<br> return 1 + gclistlen(gcnext(root), gcref(root))<br> <br> gclen = {<br>- 'root': gclistlen,<br>- 'gray': gclistlen,<br>+ 'root': gclistlen,<br>+ 'gray': gclistlen,<br> 'grayagain': gclistlen,<br>- 'weak': gclistlen,<br>+ 'weak': gclistlen,<br> # XXX: gc.mmudata is a ring-list.<br>- 'mmudata': gcringlen,<br>+ 'mmudata': gcringlen,<br> }<br> <br> def dump_gc(g):<br>@@ -582,37 +582,37 @@ def dump_lj_invalid(tv):<br> return 'not valid type @ {}'.format(strx64(gcval(tv.gcr)))<br> <br> dumpers = {<br>- 'LJ_TNIL': dump_lj_tnil,<br>- 'LJ_TFALSE': dump_lj_tfalse,<br>- 'LJ_TTRUE': dump_lj_ttrue,<br>+ 'LJ_TNIL': dump_lj_tnil,<br>+ 'LJ_TFALSE': dump_lj_tfalse,<br>+ 'LJ_TTRUE': dump_lj_ttrue,<br> 'LJ_TLIGHTUD': dump_lj_tlightud,<br>- 'LJ_TSTR': dump_lj_tstr,<br>- 'LJ_TUPVAL': dump_lj_tupval,<br>- 'LJ_TTHREAD': dump_lj_tthread,<br>- 'LJ_TPROTO': dump_lj_tproto,<br>- 'LJ_TFUNC': dump_lj_tfunc,<br>- 'LJ_TTRACE': dump_lj_ttrace,<br>- 'LJ_TCDATA': dump_lj_tcdata,<br>- 'LJ_TTAB': dump_lj_ttab,<br>- 'LJ_TUDATA': dump_lj_tudata,<br>- 'LJ_TNUMX': dump_lj_tnumx,<br>+ 'LJ_TSTR': dump_lj_tstr,<br>+ 'LJ_TUPVAL': dump_lj_tupval,<br>+ 'LJ_TTHREAD': dump_lj_tthread,<br>+ 'LJ_TPROTO': dump_lj_tproto,<br>+ 'LJ_TFUNC': dump_lj_tfunc,<br>+ 'LJ_TTRACE': dump_lj_ttrace,<br>+ 'LJ_TCDATA': dump_lj_tcdata,<br>+ 'LJ_TTAB': dump_lj_ttab,<br>+ 'LJ_TUDATA': dump_lj_tudata,<br>+ 'LJ_TNUMX': dump_lj_tnumx,<br> }<br> <br> LJ_T = {<br>- 'NIL' : i2notu32(0),<br>- 'FALSE' : i2notu32(1),<br>- 'TRUE' : i2notu32(2),<br>- 'LIGHTUD' : i2notu32(3),<br>- 'STR' : i2notu32(4),<br>- 'UPVAL' : i2notu32(5),<br>- 'THREAD' : i2notu32(6),<br>- 'PROTO' : i2notu32(7),<br>- 'FUNC' : i2notu32(8),<br>- 'TRACE' : i2notu32(9),<br>- 'CDATA' : i2notu32(10),<br>- 'TAB' : i2notu32(11),<br>- 'UDATA' : i2notu32(12),<br>- 'NUMX' : i2notu32(13),<br>+ 'NIL': i2notu32(0),<br>+ 'FALSE': i2notu32(1),<br>+ 'TRUE': i2notu32(2),<br>+ 'LIGHTUD': i2notu32(3),<br>+ 'STR': i2notu32(4),<br>+ 'UPVAL': i2notu32(5),<br>+ 'THREAD': i2notu32(6),<br>+ 'PROTO': i2notu32(7),<br>+ 'FUNC': i2notu32(8),<br>+ 'TRACE': i2notu32(9),<br>+ 'CDATA': i2notu32(10),<br>+ 'TAB': i2notu32(11),<br>+ 'UDATA': i2notu32(12),<br>+ 'NUMX': i2notu32(13),<br> }<br> <br> def itypemap(o):<br>@@ -635,22 +635,22 @@ FRAME_P = 0x4<br> FRAME_TYPEP = FRAME_TYPE | FRAME_P<br> <br> FRAME = {<br>- 'LUA': 0x0,<br>- 'C': 0x1,<br>- 'CONT': 0x2,<br>- 'VARG': 0x3,<br>- 'LUAP': 0x4,<br>- 'CP': 0x5,<br>- 'PCALL': 0x6,<br>+ 'LUA': 0x0,<br>+ 'C': 0x1,<br>+ 'CONT': 0x2,<br>+ 'VARG': 0x3,<br>+ 'LUAP': 0x4,<br>+ 'CP': 0x5,<br>+ 'PCALL': 0x6,<br> 'PCALLH': 0x7,<br> }<br> <br> def frametypes(ft):<br> return {<br>- FRAME['LUA'] : 'L',<br>- FRAME['C'] : 'C',<br>- FRAME['CONT'] : 'M',<br>- FRAME['VARG'] : 'V',<br>+ FRAME['LUA']: 'L',<br>+ FRAME['C']: 'C',<br>+ FRAME['CONT']: 'M',<br>+ FRAME['VARG']: 'V',<br> }.get(ft, '?')<br> <br> def bc_a(ins):<br>@@ -838,8 +838,8 @@ The command requires no args and dumps current VM and GC states<br> g = G(L(None))<br> print('{}'.format('\n'.join(<br> map(lambda t: '{} state: {}'.format(*t), {<br>- 'VM': vm_state(g),<br>- 'GC': gc_state(g),<br>+ 'VM': vm_state(g),<br>+ 'GC': gc_state(g),<br> 'JIT': jit_state(g),<br> }.items())<br> )))<br>@@ -1024,12 +1024,12 @@ def configure(debugger):<br> def __lldb_init_module(debugger, internal_dict):<br> configure(debugger)<br> register_commands(debugger, {<br>- 'lj-tv': LJDumpTValue,<br>+ 'lj-tv': LJDumpTValue,<br> 'lj-state': LJState,<br>- 'lj-arch': LJDumpArch,<br>- 'lj-gc': LJGC,<br>- 'lj-str': LJDumpString,<br>- 'lj-tab': LJDumpTable,<br>+ 'lj-arch': LJDumpArch,<br>+ 'lj-gc': LJGC,<br>+ 'lj-str': LJDumpString,<br>+ 'lj-tab': LJDumpTable,<br> 'lj-stack': LJDumpStack,<br> })<br> print('luajit_lldb.py is successfully loaded')<br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>