<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16910486461438061438_BODY">Fixed 10 occurrences of E305 ("expected 2 blank lines after class or<br>function definition, found 1") error reported by pycodestyle[1].<br>Furthermore, some other spots have been re-aligned the similar way to be<br>in sync with the default code style.<br><br>[1]: <a href="https://www.flake8rules.com/rules/E305.html" target="_blank">https://www.flake8rules.com/rules/E305.html</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> src/luajit-gdb.py | 15 +++++++++++++++<br> src/luajit_lldb.py | 10 ++++++++++<br> 2 files changed, 25 insertions(+)<br><br>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py<br>index 9c51be0b..3babb1d5 100644<br>--- a/src/luajit-gdb.py<br>+++ b/src/luajit-gdb.py<br>@@ -7,6 +7,7 @@ import sys<br> <br> # make script compatible with the ancient Python {{{<br> <br>+<br> LEGACY = re.match(r'^2\.', sys.version)<br> <br> if LEGACY:<br>@@ -14,8 +15,10 @@ if LEGACY:<br> int = long<br> range = xrange<br> <br>+<br> # }}}<br> <br>+<br> gtype_cache = {}<br> <br> <br>@@ -70,8 +73,10 @@ def strx64(val):<br> return re.sub('L?$', '',<br> hex(int(cast('uint64_t', val) & 0xFFFFFFFFFFFFFFFF)))<br> <br>+<br> # Types {{{<br> <br>+<br> LJ_T = {<br> 'NIL': i2notu32(0),<br> 'FALSE': i2notu32(1),<br>@@ -95,10 +100,12 @@ def typenames(value):<br> LJ_T[k]: 'LJ_T' + k for k in LJ_T.keys()<br> }.get(int(value), 'LJ_TINVALID')<br> <br>+<br> # }}}<br> <br> # Frames {{{<br> <br>+<br> FRAME_TYPE = 0x3<br> FRAME_P = 0x4<br> FRAME_TYPEP = FRAME_TYPE | FRAME_P<br>@@ -175,10 +182,12 @@ def frame_prev(framelink):<br> def frame_sentinel(L):<br> return mref('TValue *', L['stack']) + LJ_FR2<br> <br>+<br> # }}}<br> <br> # Const {{{<br> <br>+<br> LJ_64 = None<br> LJ_GC64 = None<br> LJ_FR2 = None<br>@@ -194,6 +203,7 @@ LJ_LIGHTUD_BITS_LO = 47 - LJ_LIGHTUD_BITS_SEG<br> LIGHTUD_SEG_MASK = (1 << LJ_LIGHTUD_BITS_SEG) - 1<br> LIGHTUD_LO_MASK = (1 << LJ_LIGHTUD_BITS_LO) - 1<br> <br>+<br> # }}}<br> <br> <br>@@ -339,6 +349,7 @@ def gcringlen(root):<br> else:<br> return 1 + gclistlen(gcnext(root), gcref(root))<br> <br>+<br> gclen = {<br> 'root': gclistlen,<br> 'gray': gclistlen,<br>@@ -374,6 +385,7 @@ def lightudV(tv):<br> else:<br> return gcval(tv['gcr'])<br> <br>+<br> # Dumpers {{{<br> <br> <br>@@ -465,8 +477,10 @@ def dump_lj_tnumx(tv):<br> def dump_lj_invalid(tv):<br> return 'not valid type @ {}'.format(strx64(gcval(tv['gcr'])))<br> <br>+<br> # }}}<br> <br>+<br> dumpers = {<br> 'LJ_TNIL': dump_lj_tnil,<br> 'LJ_TFALSE': dump_lj_tfalse,<br>@@ -867,4 +881,5 @@ def load(event=None):<br> 'lj-gc': LJGC,<br> })<br> <br>+<br> load(None)<br>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py<br>index bdd9e716..325b40ec 100644<br>--- a/src/luajit_lldb.py<br>+++ b/src/luajit_lldb.py<br>@@ -18,6 +18,8 @@ LJ_GCVMASK = ((1 << 47) - 1)<br> LJ_TISNUM = None<br> <br> # Debugger specific {{{<br>+<br>+<br> # Global<br> target = None<br> <br>@@ -121,6 +123,7 @@ class Struct(metaclass=MetaStruct):<br> def addr(self):<br> return self.value.address_of<br> <br>+<br> c_structs = {<br> 'MRef': [<br> (property(lambda self: self['ptr64'].unsigned if LJ_GC64 else self['ptr32'].unsigned), 'ptr')<br>@@ -212,9 +215,11 @@ c_structs = {<br> 'BCIns': []<br> }<br> <br>+<br> for cls in c_structs.keys():<br> globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]})<br> <br>+<br> for cls in Struct.__subclasses__():<br> ptr_name = cls.__name__ + 'Ptr'<br> <br>@@ -363,6 +368,7 @@ def dbg_eval(expr):<br> frame = thread.GetSelectedFrame()<br> return frame.EvaluateExpression(expr)<br> <br>+<br> # }}} Debugger specific<br> <br> <br>@@ -396,6 +402,7 @@ def gcringlen(root):<br> else:<br> return 1 + gclistlen(gcnext(root), gcref(root))<br> <br>+<br> gclen = {<br> 'root': gclistlen,<br> 'gray': gclistlen,<br>@@ -630,6 +637,7 @@ def dump_lj_tnumx(tv):<br> def dump_lj_invalid(tv):<br> return 'not valid type @ {}'.format(strx64(gcval(tv.gcr)))<br> <br>+<br> dumpers = {<br> 'LJ_TNIL': dump_lj_tnil,<br> 'LJ_TFALSE': dump_lj_tfalse,<br>@@ -647,6 +655,7 @@ dumpers = {<br> 'LJ_TNUMX': dump_lj_tnumx,<br> }<br> <br>+<br> LJ_T = {<br> 'NIL': i2notu32(0),<br> 'FALSE': i2notu32(1),<br>@@ -682,6 +691,7 @@ def typenames(value):<br> def dump_tvalue(tvptr):<br> return dumpers.get(typenames(itypemap(tvptr)), dump_lj_invalid)(tvptr)<br> <br>+<br> FRAME_TYPE = 0x3<br> FRAME_P = 0x4<br> FRAME_TYPEP = FRAME_TYPE | FRAME_P<br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>