<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>I don’t think `coroutine` is a great name.`lua_state` seems</div><div>to be a better option here.</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 3 августа 2023, 10:44 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16910486541919323878_BODY">Fixed 3 occurrences of E741 ("ambiguous variable name 'l'") error<br>reported by pycodestyle[1].<br><br>[1]: <a href="https://www.flake8rules.com/rules/E741.html" target="_blank">https://www.flake8rules.com/rules/E741.html</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> src/luajit-gdb.py | 6 +++---<br> src/luajit_lldb.py | 12 ++++++------<br> 2 files changed, 9 insertions(+), 9 deletions(-)<br><br>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py<br>index a0c8f24e..2e0b145b 100644<br>--- a/src/luajit-gdb.py<br>+++ b/src/luajit-gdb.py<br>@@ -233,15 +233,15 @@ def L(L=None):<br> # lookup a symbol for the main coroutine considering the host app<br> # XXX Fragile: though the loop initialization looks like a crap but it<br> # respects both Python 2 and Python 3.<br>- for l in [L] + list(map(lambda l: lookup(l), (<br>+ for coroutine in [L] + list(map(lambda main: lookup(main), (<br> # LuaJIT main coro (see luajit/src/luajit.c)<br> 'globalL',<br> # Tarantool main coro (see tarantool/src/lua/init.h)<br> 'tarantool_L',<br> # TODO: Add more<br> ))):<br>- if l:<br>- return cast('lua_State *', l)<br>+ if coroutine:<br>+ return cast('lua_State *', coroutine)<br> <br> <br> def G(L):<br>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py<br>index 4787c62c..76fb3141 100644<br>--- a/src/luajit_lldb.py<br>+++ b/src/luajit_lldb.py<br>@@ -453,15 +453,15 @@ def L(L=None):<br> # lookup a symbol for the main coroutine considering the host app<br> # XXX Fragile: though the loop initialization looks like a crap but it<br> # respects both Python 2 and Python 3.<br>- for l in [L] + list(map(lambda l: lookup_global(l), (<br>+ for coroutine in [L] + list(map(lambda main: lookup_global(main), (<br> # LuaJIT main coro (see luajit/src/luajit.c)<br> 'globalL',<br> # Tarantool main coro (see tarantool/src/lua/init.h)<br> 'tarantool_L',<br> # TODO: Add more<br> ))):<br>- if l:<br>- return lua_State(l)<br>+ if coroutine:<br>+ return lua_State(coroutine)<br> <br> <br> def tou32(val):<br>@@ -1066,9 +1066,9 @@ coroutine guest stack:<br> If L is ommited the main coroutine is used.<br> '''<br> def execute(self, debugger, args, result):<br>- l = self.parse(args)<br>- l_ptr = cast('lua_State *', l) if l is not None else None<br>- print('{}'.format(dump_stack(L(l_ptr))))<br>+ coro = self.parse(args)<br>+ coro_ptr = cast('lua_State *', coro) if coro is not None else None<br>+ print('{}'.format(dump_stack(L(coro_ptr))))<br> <br> <br> def register_commands(debugger, commands):<br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></BODY></HTML>