<HTML><BODY><div>Hi!</div><div>Thanks for the fixes!</div><div>LGTM</div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16894341780493588707_BODY">Hi, Maxim!<br>Thanks for the review!<br>Fixed your comments! Branch is force-pushed.<br><br>On 14.07.23, Maxim Kokryashkin wrote:<br>><br>> Hi!<br>> Thanks for the patch!<br>> LGTM, except for a few nits regarding the commit message.<br>> <br>> > <br>> >>From: Mike Pall <mike><br>> >><br>> >>Analyzed by Sergey Kaplun.<br>> >><br>> >>(cherry-picked from commit 94ada59628dd6ce5d6d2dad1d35a68ad30127f53)<br>> >><br>> >>While recording BC_VARG `J->maxslot` isn't shrunk to the effective stack<br>> >Typo: s/shrunk/shrinking<br><br>I meant the third form shrink/shrank/shrunk here. Ignoring.<br><br>> >>top. This leads to dead value stored in the JIT slots and the following<br>> >Typo: s/value/values/<br><br>Fixed.<br><br>> >>assertion failure for these slots check in `rec_check_slots()`. Note,<br>> >>that `rec_varg()` modifies `maxslot` only under the condition that<br>> >>`maxslot` should be increased, but the dead values are left for the<br>> >>opposite case.<br>> >><br>> >>This patch removes the condition inside `rec_varg()` only for the case<br>> >>when varargs are not defined on trace (`framedepth` is 0), but the<br>> >>similar issue still occurs for the case when vararg are defined on the<br>> >Typo: s/vararg/varagrs/<br>> >>trace.<br><br>Fixed.<br><br>> >><br>> >>Sergey Kaplun:<br>> >>* added the description and the test for the problem<br>> >><br>> >>Part of tarantool/tarantool#8825<br><br><snipped><br><br>> >--<br>> >Best regards,<br>> >Maxim Kokryashkin<br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>