<HTML><BODY><div>Hi, Sergey!</div><div>Thanks for the patch!</div><div>LGTM</div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 18 мая 2023, 23:49 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16844429421535697057_BODY">When we set `LUA_TEST_ENV_MORE` variable to be used in the additional<br>env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH`<br>value the content of this environment variable is literally<br>`"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the<br>relative path starting with `"`. In that case if we need the library to<br>be loaded via FFI for this particular test, that loading fails with the<br>error "cannot open shared object file", since the path to it is<br>incorrect.<br><br>This patch removes `"` wrapping for the aforementioned variables.<br>---<br> test/tarantool-tests/CMakeLists.txt | 9 +++++++--<br> 1 file changed, 7 insertions(+), 2 deletions(-)<br><br>diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt<br>index a428d009..38d6ae49 100644<br>--- a/test/tarantool-tests/CMakeLists.txt<br>+++ b/test/tarantool-tests/CMakeLists.txt<br>@@ -102,6 +102,11 @@ endif()<br> # loaded modules on MacOS instead of shared libraries as it is<br> # done on Linux and BSD, another environment variable should be<br> # used to guide <ffi.load> while searching the extension.<br>+# XXX: Be noticed that we shouldn't use `"` here to wrap<br>+# the variable's content. If we do this, the variable value will<br>+# contain `"` at the beginning and the end, so this `"` at the<br>+# beginning will be treated as the directory for the first entry<br>+# (the last subdirectory added).<br> if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br> # XXX: Apple tries their best to "protect their users from<br> # malware". As a result SIP (see the link[1] below) has been<br>@@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")<br> #<br> # [1]: <a href="https://support.apple.com/en-us/HT204899" target="_blank">https://support.apple.com/en-us/HT204899</a><br> # [2]: <a href="https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html" target="_blank">https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html</a><br>- list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}")<br>+ list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH})<br> else()<br>- list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}")<br>+ list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH})<br> endif()<br> <br> # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list<br>--<br>2.34.1</div></div></div></div></blockquote><div> </div></BODY></HTML>