<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16776110221242438051_BODY">lua-Harness considers whether JIT is enabled or not in the scope of the<br>403-jit.t and 411-luajit.t tests. However, the original condition is<br>wrong, since <jit.status> yields false for both cases, when JIT is just<br>turned off and when LuaJIT is built without compiler support. So, if<br><jit.status> yields false, the latter case is considered. The condition<br>is fixed to differ both aforementioned cases in the following way: when<br>jit.opt is nil, LuaJIT is built without compiler; otherwise, JIT support<br>is on board.<br><br>Part of tarantool/tarantool#8252<br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> test/lua-Harness-tests/403-jit.t | 2 +-<br> test/lua-Harness-tests/411-luajit.t | 2 +-<br> 2 files changed, 2 insertions(+), 2 deletions(-)<br><br>diff --git a/test/lua-Harness-tests/403-jit.t b/test/lua-Harness-tests/403-jit.t<br>index 0f986da9..1a88564b 100755<br>--- a/test/lua-Harness-tests/403-jit.t<br>+++ b/test/lua-Harness-tests/403-jit.t<br>@@ -31,7 +31,7 @@ if not jit then<br> skip_all("only with LuaJIT")<br> end<br> <br>-local compiled_with_jit = jit.status()<br>+local compiled_with_jit = jit.opt ~= nil<br> local luajit20 = jit.version_num < 20100 and not jit.version:match'RaptorJIT'<br> local has_jit_opt = compiled_with_jit<br> local has_jit_security = jit.security<br>diff --git a/test/lua-Harness-tests/411-luajit.t b/test/lua-Harness-tests/411-luajit.t<br>index 3a9a7b8f..6cfd6837 100755<br>--- a/test/lua-Harness-tests/411-luajit.t<br>+++ b/test/lua-Harness-tests/411-luajit.t<br>@@ -37,7 +37,7 @@ if not pcall(io.popen, lua .. [[ -e "a=1"]]) then<br> skip_all("io.popen not supported")<br> end<br> <br>-local compiled_with_jit = jit.status()<br>+local compiled_with_jit = jit.opt ~= nil<br> local has_jutil = pcall(require, 'jit.util')<br> local has_openresty_listing = profile.openresty or jit.version:match'moonjit'<br> <br>--<br>2.30.2</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>