<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the fixes!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16776111050767727868_BODY">Max,<br><br>Thanks for your review! I've fixed the comments you've left.<br><br>On 16.02.23, Maxim Kokryashkin wrote:<br>><br>> Hi, Igor!<br>> Thanks for the patch!<br>> Please consider my comments below.<br>> <br>> `lj-906-fix-err-mem.test.lua` has a `jit.off()`<br>> call in the line 78, which should be wrapped in a pcall.<br><br>Hm, thanks for noticing! Fun fact: jit.off doesn't raise the error when<br>JIT is not compiled. I guess we can left pcall only for jit.flush calls.<br><br>> <br>> This change should be moved to commit<br>> «build: fix build with JIT disabled»<br>> (a835fb0f778db6e9f0109a66ea1d2ac78fe682e4)<br>> along with the change that I pointed out below.<br><br>As we discussed offline, these changes should be left here. Ignoring.<br><br>> > <br><br><snipped><br><br>> --<br>> Best regards,<br>> Maxim Kokryashkin<br>> <br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>