<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM, except for a few nits regarding the commit message:</div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 27 февраля 2023, 12:10 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16774890051016369822_BODY">Sometimes one need to skip the remaining tests in the script. There is<br>no special stub in TAP13 protocol for this, but this could be done via</div></div></div></div></blockquote><div>Typo: s/TAP 13/the TAP 13/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>skipping all the remaining planned tests.<br><br>Within this commit <test:skiprest> helper is introduced that calls<br><test:skip> (planned - total) times and exits the test script. As for<br>the previous commit it's worth to mention, that skiprest helper is</div></div></div></div></blockquote><div>Typo: s/worth to mention/worth mentioning/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>implemented only for root (i.e. test with no parent) tests and subtests<br>are not supported at the moment. The corresponding assertion with FIXME<br>reason can be found in <finalize> routine.<br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> test/tarantool-tests/tap.lua | 8 ++++++++<br> 1 file changed, 8 insertions(+)<br><br>diff --git a/test/tarantool-tests/tap.lua b/test/tarantool-tests/tap.lua<br>index 92d59ce9..343f97e3 100644<br>--- a/test/tarantool-tests/tap.lua<br>+++ b/test/tarantool-tests/tap.lua<br>@@ -101,6 +101,13 @@ local function skipall(test, reason)<br> finalize(test)<br> end<br> <br>+local function skiprest(test, reason)<br>+ for _ = 1, test.planned - test.total do<br>+ test:skip(reason)<br>+ end<br>+ finalize(test)<br>+end<br>+<br> local function like(test, got, pattern, message, extra)<br> extra = extra or {}<br> extra.got = got<br>@@ -330,6 +337,7 @@ test_mt = {<br> fail = fail,<br> skip = skip,<br> skipall = skipall,<br>+ skiprest = skiprest,<br> is = is,<br> isnt = isnt,<br> isnil = isnil,<br>--<br>2.30.2</div></div></div></div></blockquote><div><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div><div> </div></BODY></HTML>