<HTML><BODY><div>Hi, Sergey!</div><div>Thanks for the patch!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16756680461756141753_BODY">This commit adds the build with the aforementioned option to test<br>on x86_64 and arm64 architectures to exotic build matrix.<br>---<br><br>Branch: <a href="https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook" target="_blank">https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook</a><br>Workflow example: <a href="https://github.com/tarantool/luajit/actions/runs/4101136217" target="_blank">https://github.com/tarantool/luajit/actions/runs/4101136217</a><br><br> .github/workflows/exotic-builds-testing.yml | 15 +++++++++++----<br> 1 file changed, 11 insertions(+), 4 deletions(-)<br><br>diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml<br>index cd0c14d7..aaf4f9f6 100644<br>--- a/.github/workflows/exotic-builds-testing.yml<br>+++ b/.github/workflows/exotic-builds-testing.yml<br>@@ -29,13 +29,14 @@ concurrency:<br> cancel-in-progress: true<br> <br> jobs:<br>- test-x86_64-exotic:<br>+ test-exotic:<br> strategy:<br> fail-fast: false<br> matrix:<br> BUILDTYPE: [Debug, Release]<br>+ ARCH: [ARM64, x86_64]<br> GC64: [ON, OFF]<br>- FLAVOR: [dualnum]<br>+ FLAVOR: [dualnum, checkhook]<br> include:<br> - BUILDTYPE: Debug<br> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON<br>@@ -43,10 +44,16 @@ jobs:<br> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo<br> - FLAVOR: dualnum<br> FLAVORFLAGS: -DLUAJIT_NUMMODE=2<br>- runs-on: [self-hosted, regular, Linux, x86_64]<br>+ - FLAVOR: checkhook<br>+ FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON<br>+ exclude:<br>+ # DUALNUM is default for ARM64, no need for additional testing.<br>+ - FLAVOR: dualnum<br>+ ARCH: ARM64<br>+ runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']<br> name: ><br> LuaJIT ${{ matrix.FLAVOR }}<br>- (Linux/x86_64)<br>+ (Linux/${{ matrix.ARCH }})<br> ${{ matrix.BUILDTYPE }}<br> GC64:${{ matrix.GC64 }}<br> steps:<br>--<br>2.34.1</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>