<HTML><BODY><div>Hi, Sergey!</div><div>Thanks for the patch!</div><div>LGTM, except for the single nit regarding the commit title.</div><div>I believe, it should be the `string.format` instead of `string.char`.</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16741456131140933186_BODY">This patch adds the test for the commit<br>430d9f8f7ebb779948dbd43944b876b1a3f58551 ("Fix string.format("%c",<br>0)."). Although, the issue affects 2.0 branch only, there is no need to<br>fix it. Nevertheless, the test is required to avoid regressions in the<br>future.<br><br>Part of tarantool/tarantool#8069<br>---<br><br>PR: <a href="https://github.com/tarantool/tarantool/pull/8189" target="_blank">https://github.com/tarantool/tarantool/pull/8189</a><br>Branch: <a href="https://github.com/tarantool/luajit/tree/skaplun/lj-378-string-format-c-null-char-full-ci" target="_blank">https://github.com/tarantool/luajit/tree/skaplun/lj-378-string-format-c-null-char-full-ci</a><br>Issues:<br>* <a href="https://github.com/tarantool/tarantool/issues/8069" target="_blank">https://github.com/tarantool/tarantool/issues/8069</a><br>* <a href="https://github.com/LuaJIT/LuaJIT/issues/378" target="_blank">https://github.com/LuaJIT/LuaJIT/issues/378</a><br><br> .../lj-378-string-format-c-null-char.test.lua | 11 +++++++++++<br> 1 file changed, 11 insertions(+)<br> create mode 100644 test/tarantool-tests/lj-378-string-format-c-null-char.test.lua<br><br>diff --git a/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua b/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua<br>new file mode 100644<br>index 00000000..15cefadf<br>--- /dev/null<br>+++ b/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua<br>@@ -0,0 +1,11 @@<br>+local tap = require('tap')<br>+<br>+local test = tap.test('lj-378-string-format-c-null-char')<br>+test:plan(1)<br>+<br>+-- Test file to check that there is no regression in<br>+-- `string.format('%c', 0)` behaviour.<br>+-- See also <a href="https://github.com/LuaJIT/LuaJIT/issues/378" target="_blank">https://github.com/LuaJIT/LuaJIT/issues/378</a>.<br>+<br>+test:is(string.format('%c', 0), '\0', 'string.format %c on null char')<br>+os.exit(test:check() and 0 or 1)<br>--<br>2.34.1</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>