<HTML><BODY><div>Hi!</div><div>Thanks for the fixes!</div><div>LGTM</div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 16 января 2023, 11:10 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16738566411528296040_BODY">Sergey,<br><br>Thanks for your review!<br><br>On 13.01.23, Sergey Kaplun wrote:<br>> Hi, Igor!<br>><br>> Thanks for the patch!<br>> LGTM, with a single question below.<br>><br>> On 13.01.23, Maxim Kokryashkin wrote:<br>> ><br>> > Hi, Igor!<br>> > Thanks for the patch!<br>> > LGTM, except for a few nits below.<br><br>Added your tag:<br>| Reviewed-by: Sergey Kaplun <<a href="/compose?To=skaplun@tarantool.org">skaplun@tarantool.org</a>><br><br>> > <br><br><snipped><br><br>> > >>"regular" ones need to be chosen for full LuaJIT testing. At the same<br>> > >>time there is no need to use "regular" runner for LuaJIT Static analysis<br>> > >>workflow, hence 'lightweight' label is added to <runs-on> list in<br>> > >>lint.yml workflow file.<br>> > >Shall we create the same patch for the gnumake workflow?<br>><br>> I agree here. IMHO, we can use "lightweight" label for gnumake build as<br>> far as it tests only build, so doesn't require a lot of memory.<br><br>Replied to the Max thread.<br><br>><br><br><snipped><br><br>><br>> --<br>> Best regards,<br>> Sergey Kaplun<br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote><div> </div></BODY></HTML>