<HTML><BODY><div>Hi!</div><div>Thanks for the patch!</div><div>LGTM, except for a few nits below.</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16735359872061994099_BODY">Considering the changes made in scope of the previous commit, it has<br>been decided to dispatch LuaJIT integration testing to the runner the<br>similar way (i.e. by using the pair of <matrix.ARCH> + <matrix.OS><br>values). As a result a new job with quite similar strategy matrix[1] is<br>added as a successor for <test-luajit> job. The new job uses the new<br>version (with <inputs.arch> and <inputs.os> parameters introduced and<br>optional <inputs.host> obsolete parameter) of LuaJIT integration</div></div></div></div></blockquote><div>Typo: s/optional/the optional/</div><div>Typo: s/of LuaJIT/of the LuaJIT/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>workflow from tarantool/tarantool repo.</div></div></div></div></blockquote><div>Typo: s/from/from the/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><br>[1]: <a href="https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow" target="_blank">https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow</a><br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> .github/workflows/testing.yml | 190 ++++++----------------------------<br> 1 file changed, 30 insertions(+), 160 deletions(-)<br><br>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml<br>index 5558e3ea..d707ce83 100644<br>--- a/.github/workflows/testing.yml<br>+++ b/.github/workflows/testing.yml<br>@@ -77,173 +77,43 @@ jobs:<br> run: cmake --build . --parallel --target test<br> working-directory: ${{ env.BUILDDIR }}<br> <br>- test-tarantool-linux-x86_64-debug-wo-GC64:<br>- name: Tarantool (Linux/x86_64) Debug GC64:OFF<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=Debug<br>- -DLUAJIT_ENABLE_GC64=OFF<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: OFF<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: Debug<br>- host: ubuntu-20.04-self-hosted<br>- revision: ${{ github.sha }}<br>- test-tarantool-linux-x86_64-debug-w-GC64:<br>- name: Tarantool (Linux/x86_64) Debug GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=Debug<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: Debug<br>- host: ubuntu-20.04-self-hosted<br>- revision: ${{ github.sha }}<br>- test-tarantool-linux-x86_64-release-wo-GC64:<br>- name: Tarantool (Linux/x86_64) Release GC64:OFF<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=RelWithDebInfo<br>- -DLUAJIT_ENABLE_GC64=OFF<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: OFF<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: RelWithDebInfo<br>- host: ubuntu-20.04-self-hosted<br>- revision: ${{ github.sha }}<br>- test-tarantool-linux-x86_64-release-w-GC64:<br>- name: Tarantool (Linux/x86_64) Release GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=RelWithDebInfo<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: RelWithDebInfo<br>- host: ubuntu-20.04-self-hosted<br>- revision: ${{ github.sha }}<br>- test-tarantool-linux-aarch64-debug-w-GC64:<br>- name: Tarantool (Linux/aarch64) Debug GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=Debug<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: Debug<br>- host: graviton<br>- revision: ${{ github.sha }}<br>- test-tarantool-linux-aarch64-release-w-GC64:<br>- name: Tarantool (Linux/aarch64) Release GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=RelWithDebInfo<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: RelWithDebInfo<br>- host: graviton<br>- revision: ${{ github.sha }}<br>- test-tarantool-macos-x86_64-debug-w-GC64:<br>- name: Tarantool (macOS/x86_64) Debug GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=Debug<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: Debug<br>- host: macos-11<br>- revision: ${{ github.sha }}<br>- test-tarantool-macos-x86_64-release-w-GC64:<br>- name: Tarantool (macOS/x86_64) Release GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=RelWithDebInfo<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: RelWithDebInfo<br>- host: macos-11<br>- revision: ${{ github.sha }}<br>- test-tarantool-macos-m1-debug-w-GC64:<br>- name: Tarantool (macOS/M1) Debug GC64:ON<br>- needs: test-luajit<br>- uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br>- with:<br>- CMAKE_EXTRA_PARAMS: ><br>- -G Ninja<br>- -DCMAKE_BUILD_TYPE=Debug<br>- -DLUAJIT_ENABLE_GC64=ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>- # FIXME: This parameter is obsolete, drop it when<br>- # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: Debug<br>- host: macos-11-m1<br>- revision: ${{ github.sha }}<br>- test-tarantool-macos-m1-release-w-GC64:<br>- name: Tarantool (macOS/M1) Release GC64:ON<br>+<br>+ test-tarantool:<br>+ strategy:<br>+ fail-fast: false<br>+ matrix:<br>+ ARCH: [ARM64, x86_64]<br>+ BUILDTYPE: [Debug, Release]<br>+ GC64: [ON, OFF]<br>+ OS: [Linux, macOS]<br>+ include:<br>+ - BUILDTYPE: Debug<br>+ CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug<br>+ - BUILDTYPE: Release<br>+ CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo<br>+ exclude:<br>+ - ARCH: ARM64<br>+ GC64: OFF<br>+ - OS: macOS<br>+ GC64: OFF<br>+ name: ><br>+ Tarantool<br>+ (${{ matrix.OS }}/${{ matrix.ARCH }})<br>+ ${{ matrix.BUILDTYPE }}<br>+ GC64:${{ matrix.GC64 }}<br> needs: test-luajit<br> uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master<br> with:<br> CMAKE_EXTRA_PARAMS: ><br> -G Ninja<br>- -DCMAKE_BUILD_TYPE=RelWithDebInfo<br>- -DLUAJIT_ENABLE_GC64=ON<br>+ ${{ matrix.CMAKEFLAGS }}<br>+ -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}<br> # FIXME: This parameter is obsolete, drop it when<br> # CMAKE_EXTRA_PARAMS is activated.<br>- GC64: ON<br>+ GC64: ${{ matrix.GC64 }}<br>+ arch: ${{ matrix.ARCH }}<br>+ os: ${{ matrix.OS }}<br> # FIXME: This parameter is obsolete, drop it when<br> # CMAKE_EXTRA_PARAMS is activated.<br>- buildtype: RelWithDebInfo<br>- host: macos-11-m1<br>+ buildtype: ${{ matrix.BUILDTYPE }}<br> revision: ${{ github.sha }}<br>--<br>2.34.0</div></div></div></div></blockquote><div><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div></blockquote></BODY></HTML>