<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM, except for a few nits below.</div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16735359870509119534_BODY">Before the patch the all LuaJIT testing jobs were dispatched to the</div></div></div></div></blockquote><div>Typo: s/the all/, all/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>runner with the name given via strategy matrix <RUNNER> entry. However,</div></div></div></div></blockquote><div>Typo: s/via/via the/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>more convenient way for dispatching is the triplet of the following</div></div></div></div></blockquote><div>Typo: s/more/a more/</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>labels:<br>* <matrix.ARCH> to specify the host architecture (i.e. x86_64 or ARM64)<br>* <matrix.OS> to specify the OS family name (either Linux or macOS)<br>* 'self-hosted' to make job dispatch only to the runners from Tarantool<br> ghacts-shared-* pool and never choose GitHub public resources.<br><br>With the given triplet the proper runner is chosen for the particular<br>testing flavor.<br><br>Moreover, the new 'lightweight' and 'regular' labels are also used in<br><runs-on> list, since the new "lightweight" runners have been introduced<br>to ghacts-shared-* pool. There are a couple of LuaJIT tests that<br>requires more memory than provided by "lightweight" runners, so only</div></div></div></div></blockquote><div>Typo: s/requires/require/</div><div>Typo: s/than/than is/</div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>"regular" ones need to be chosen for full LuaJIT testing. At the same<br>time there is no need to use "regular" runner for LuaJIT Static analysis<br>workflow, hence 'lightweight' label is added to <runs-on> list in<br>lint.yml workflow file.</div></div></div></div></blockquote><div>Shall we create the same patch for the gnumake workflow?</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br> .github/workflows/gnumake-builds-testing.yml | 20 ++------------------<br> .github/workflows/lint.yml | 2 +-<br> .github/workflows/testing.yml | 20 ++------------------<br> 3 files changed, 5 insertions(+), 37 deletions(-)<br><br>diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml<br>index ad9d5015..e5f82780 100644<br>--- a/.github/workflows/gnumake-builds-testing.yml<br>+++ b/.github/workflows/gnumake-builds-testing.yml<br>@@ -38,22 +38,6 @@ jobs:<br> GC64: [ON, OFF]<br> OS: [Linux, macOS]<br> include:<br>- - ARCH: ARM64<br>- OS: Linux<br>- NAME: Linux/aarch64<br>- RUNNER: graviton<br>- - ARCH: x86_64<br>- OS: Linux<br>- NAME: Linux/x86_64<br>- RUNNER: ubuntu-20.04-self-hosted<br>- - ARCH: ARM64<br>- OS: macOS<br>- NAME: macOS/M1<br>- RUNNER: macos-11-m1<br>- - ARCH: x86_64<br>- OS: macOS<br>- NAME: macOS/x86_64<br>- RUNNER: macos-11<br> - BUILDTYPE: Debug<br> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON<br> MAKEBUILDFLAGS: -DLUA_USE_ASSERT -DLUA_USE_APICHECK<br>@@ -70,10 +54,10 @@ jobs:<br> GC64: OFF<br> - OS: macOS<br> GC64: OFF<br>- runs-on: [self-hosted, '${{ matrix.RUNNER }}']<br>+ runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']<br> name: ><br> LuaJIT<br>- (${{ matrix.NAME }})<br>+ (${{ matrix.OS }}/${{ matrix.ARCH }})<br> ${{ matrix.BUILDTYPE }}<br> GC64:${{ matrix.GC64 }}<br> steps:<br>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml<br>index e565144c..02150922 100644<br>--- a/.github/workflows/lint.yml<br>+++ b/.github/workflows/lint.yml<br>@@ -30,7 +30,7 @@ concurrency:<br> <br> jobs:<br> test-luacheck:<br>- runs-on: ubuntu-20.04-self-hosted<br>+ runs-on: [self-hosted, lightweight, Linux, x86_64]<br> name: luacheck<br> steps:<br> - uses: actions/checkout@v2.3.4<br>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml<br>index 958f8e27..5558e3ea 100644<br>--- a/.github/workflows/testing.yml<br>+++ b/.github/workflows/testing.yml<br>@@ -38,22 +38,6 @@ jobs:<br> GC64: [ON, OFF]<br> OS: [Linux, macOS]<br> include:<br>- - ARCH: ARM64<br>- OS: Linux<br>- NAME: Linux/aarch64<br>- RUNNER: graviton<br>- - ARCH: x86_64<br>- OS: Linux<br>- NAME: Linux/x86_64<br>- RUNNER: ubuntu-20.04-self-hosted<br>- - ARCH: ARM64<br>- OS: macOS<br>- NAME: macOS/M1<br>- RUNNER: macos-11-m1<br>- - ARCH: x86_64<br>- OS: macOS<br>- NAME: macOS/x86_64<br>- RUNNER: macos-11<br> - BUILDTYPE: Debug<br> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON<br> - BUILDTYPE: Release<br>@@ -63,10 +47,10 @@ jobs:<br> GC64: OFF<br> - OS: macOS<br> GC64: OFF<br>- runs-on: [self-hosted, '${{ matrix.RUNNER }}']<br>+ runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']<br> name: ><br> LuaJIT<br>- (${{ matrix.NAME }})<br>+ (${{ matrix.OS }}/${{ matrix.ARCH }})<br> ${{ matrix.BUILDTYPE }}<br> GC64:${{ matrix.GC64 }}<br> steps:<br>--<br>2.34.0</div></div></div></div></blockquote><div><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div><div> </div></div></blockquote></BODY></HTML>