<HTML><BODY><div>Hi, Igor!</div><div>Thanks for the patch!</div><div>LGTM, except for the nits, Sergey have already mentioned.</div><div data-signature-widget="container"><div spellcheck="false" data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Воскресенье, 2 октября 2022, 18:21 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16647240701043096183_BODY">Originally there is nether a special option nor a variable to configure<br>check for instrunction/line hooks for compiled code via the build system<br>being used. We finally decided to use this feature in Tarantool, so for<br>convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root<br>project CMakeLists.txt.<br><br>Needed for tarantool/tarantool#7762<br><br>Signed-off-by: Igor Munkin <<a href="/compose?To=imun@tarantool.org">imun@tarantool.org</a>><br>---<br><br>Issue: <a href="https://github.com/tarantool/tarantool/issues/7762" target="_blank">https://github.com/tarantool/tarantool/issues/7762</a><br>Branch: <a href="https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook" target="_blank">https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook</a><br>CI: <a href="https://github.com/tarantool/luajit/commit/701de8c" target="_blank">https://github.com/tarantool/luajit/commit/701de8c</a><br><br> CMakeLists.txt | 5 +++++<br> 1 file changed, 5 insertions(+)<br><br>diff --git a/CMakeLists.txt b/CMakeLists.txt<br>index 8b49f9d7..c870cce2 100644<br>--- a/CMakeLists.txt<br>+++ b/CMakeLists.txt<br>@@ -180,6 +180,11 @@ if(LUAJIT_ENABLE_GC64)<br>   AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_GC64)<br> endif()<br> <br>+option(LUAJIT_ENABLE_CHECKHOOK "Check instruction/line hooks for compiled code" OFF)<br>+if(LUAJIT_ENABLE_CHECKHOOK)<br>+ AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_CHECKHOOK)<br>+endif()<br>+<br> # Disable memory profiler.<br> option(LUAJIT_DISABLE_MEMPROF "LuaJIT memory profiler support" OFF)<br> if(LUAJIT_DISABLE_MEMPROF)<br>--<br>2.34.0</div></div></div></div></blockquote><div> </div></BODY></HTML>