<HTML><BODY><div>Hi!</div><div>Thanks for the review!</div><div>Here is the new commit message:</div><div>======================================================</div><div><div><div>test: adapt disabled tests from PUC-Rio</div></div><div> </div><div><div>Version and status are printed in stdout instead of stderr</div><div>since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior</div><div>is the same as in Lua 5.2, so necessary changes in tests can be</div><div>adapted from PUC-Rio Lua 5.2 test suite.</div></div><div> </div><div><div>However, those tests are disabled for Tarantool since its interactive</div><div>shell doesn't support '=' at the beginning of statements.</div><div>Here is an example:</div><div>| $ luajit</div><div>| > = (6*2-6) -- ===</div><div>| 6</div><div>|</div><div>| $ tarantool</div><div>| tarantool> = (6*2-6) -- ===</div><div>| ---</div><div>| - error: ' (6*2-6) -- ===:1: unexpected symbol near ''='''</div><div>| ...</div></div><div> </div><div><div>Resolves tarantool/tarantool#5687</div><div>Part of tarantool/tarantool#5870</div><div>======================================================</div><div> </div><div>And here is the diff:</div><div>======================================================</div><div><div><div>diff --git a/test/PUC-Rio-Lua-5.1-tests/main.lua b/test/PUC-Rio-Lua-5.1-tests/main.lua</div><div>index 9c1e5fa4..9894f299 100644</div><div>--- a/test/PUC-Rio-Lua-5.1-tests/main.lua</div><div>+++ b/test/PUC-Rio-Lua-5.1-tests/main.lua</div><div>@@ -34,8 +34,8 @@ function getoutput ()</div><div> return t</div><div> end</div><div> </div><div>--- Version and status are printed in stdout instead stderr since</div><div>--- LuaJIT-2.0.0-beta11 (as it is not an error message).</div><div>+-- Version and status are printed in stdout instead of stderr</div><div>+-- since LuaJIT-2.0.0-beta11 (as it is not an error message).</div><div> -- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735</div><div> -- (Print version and JIT status to stdout, not stderr.).</div><div> -- This behavior is the same as in Lua 5.2.</div></div></div><div>======================================================</div></div></div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 16 февраля 2022, 13:41 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16450080700775680792_BODY">Sergey,<br><br>On 16.12.21, Sergey Kaplun wrote:<br>> Hi, Maxim!<br>><br>> Thanks for the fixes!<br>><br>> LGTM, except a few nits below.<br>><br>> On 13.10.21, Maxim Kokryashkin wrote:<br>> > Version and status are printed in stdout instead stderr<br>> > since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior<br>> > is the same as in Lua 5.2, so necessary changes in tests can be<br>> > adapted from PUC-Rio Lua 5.2 test suite.<br>> ><br>> > However, those tests are disabled for Tarantool since its interactive<br>> > shell doesn't support '=' at the beginning of statements.<br>> > Here is an example:<br>><br>> OK, so maybe we should create a ticket for that (and _PROMPT feature)?<br>> At least to mention it and wait for thumbs up.<br>> Igor, thoughts?<br><br>I guess this is not an obligatory feature, since nobody claims Tarantool<br>console should provide the similar interfaces LuaJIT does. IMHO, the<br>best solution for this would be LuaJIT compatibility flag for Tarantool<br>or its console, but I see no demand for this. So, it's up to you to file<br>a ticket or not.<br><br>><br><br><snipped><br><br>><br>> --<br>> Best regards,<br>> Sergey Kaplun<br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote><div> </div></BODY></HTML>