<HTML><BODY><div>Hi!</div><div>Thanks for the review!</div><div> </div><div>Here is the new commit message:</div><div>=======================================================</div><div><div><div>test: adapt tests checking traceback in tail call</div></div><div> </div><div><div>LuaJIT does not provide information about tail calls,</div><div>unlike, Lua 5.1 does, so a traceback in LuaJIT may be different.</div></div><div> </div><div><div>Consider this chunk of code:</div><div>```</div><div>local function f(n)</div><div> if n > 0 then</div><div> return f(n - 1)</div><div> else</div><div> coroutine.yield()</div><div> end</div><div>end</div></div><div> </div><div><div>local co = coroutine.create(f)</div><div>coroutine.resume(co, 3)</div><div>print(debug.traceback(co))</div><div>```</div></div><div> </div><div><div>For LuaJIT traceback looks like the following:</div><div>stack traceback:</div><div> [C]: in function 'yield'</div><div> test.lua:5: in function <test.lua:1></div><div>```</div></div><div> </div><div><div>And for Lua 5.1 it looks like the following:</div><div>```</div><div>stack traceback:</div><div> [C]: in function 'yield'</div><div> test.lua:5: in function <test.lua:1></div><div> (tail call): ?</div><div> (tail call): ?</div><div> (tail call): ?</div><div>```</div></div><div> </div><div><div>This commit adapts the corresponding test to the behavior of LuaJIT, so</div><div>it doesn't check tail calls anymore.</div></div><div> </div><div><div>Resolves tarantool/tarantool#5703</div><div>Part of tarantool/tarantool#5870</div></div><div>=======================================================</div><div> </div><div>New CI branch: <a href="https://github.com/tarantool/tarantool/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio-full-ci">https://github.com/tarantool/tarantool/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio-full-ci</a></div></div><div data-signature-widget="container"><div spellcheck="false" data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16446069511979419715_BODY">Max,<br><br>Thanks for the patch! LGTM, except a couple of nits.<br><br>On 09.11.21, Максим Корякшин wrote:<br>><br>> Hi, Sergey! Thanks for the review!<br>> Here is the new commit message considering your comments:<br>> <br>> =======================================================<br>> test: adapt tests checking traceback in tail call<br>> <br>> LuaJIT does not provide information about tail calls,<br>> unlike, Lua 5.1 does, so a traceback in LuaJIT may be different.<br>> <br>> Consider this chunck of code:<br><br>Typo: s/chunck/chunk/.<br><br>> ```<br>> local function f(n)<br>> if n > 0 then<br>> return f(n - 1)<br>> else<br>> coroutine.yield()<br>> end<br>> end<br>> <br>> local co = coroutine.create(f)<br>> coroutine.resume(co, 3)<br>> print(debug.traceback(co))<br>> ```<br>> <br>> For LuaJIT traceback looks like the following:<br>> stack traceback:<br>> [C]: in function 'yield'<br>> test.lua:5: in function <test.lua:1><br>> ```<br>> <br>> And for Lua 5.1 it looks like the following:<br>> ```<br>> stack traceback:<br>> [C]: in function 'yield'<br>> test.lua:5: in function <test.lua:1><br>> (tail call): ?<br>> (tail call): ?<br>> (tail call): ?<br>> ```<br>> <br>> This commit adapts the corresponding test to the behavior of LuaJIT, so<br>> it doesn't check tail calls anymore.<br>> <br><br>Please, add "Resolves tarantool/tarantool#5703" here.<br><br>> Part of tarantool/tarantool#5870<br>> =======================================================<br>> <br>> CI: <a href="https://github.com/tarantool/tarantool/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio" target="_blank">https://github.com/tarantool/tarantool/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio</a><br>> <br>> Best regards,<br>> Maxim Kokryashkin<br><br><snipped><br><br>> <br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>