<HTML><BODY><div id="composeWebView_editable_content" data-mailruapp-compose-id="composeWebView_editable_content" style="text-align: left;"><div>Just to avoid misreading : LGTM</div><div><br></div><div id="mail-app-auto-signature">
Best regards,<div>Sergos </div>
</div><br><br>Friday, 28 January 2022, 18:11 +0300 from Kaplun Sergey <skaplun@tarantool.org>:<br><div id="composeWebView_previouse_content" data-mailruapp-compose-id="composeWebView_previouse_content" data-darkosha-id="transformer_0" style=""><blockquote id="mail-app-auto-quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(11, 102, 249); margin: 10px 0px 10px 5px; padding: 0px 0px 0px 10px; display: inherit;"><div class="js-helper js-readmsg-msg" style="">
<style type="text/css"></style>
<div style="">
<base target="_self" href="https://e.mail.ru/" style="">
<div id="style_16433826951248169546_BODY" style="">Hi, Sergos!<br style="">
<br style="">
Thanks for the review!<br style="">
<br style="">
On 28.01.22, sergos wrote:<br style="">
> Hi!<br style="">
> <br style="">
> I reviewed the one at <a href="https://github.com/tarantool/luajit/commit/2cdd5ac0367629d2f37489dd842d9a6b068cf12c" target="_blank" style="">https://github.com/tarantool/luajit/commit/2cdd5ac0367629d2f37489dd842d9a6b068cf12c</a> <<a href="https://github.com/tarantool/luajit/commit/2cdd5ac0367629d2f37489dd842d9a6b068cf12c" target="_blank" style="">https://github.com/tarantool/luajit/commit/2cdd5ac0367629d2f37489dd842d9a6b068cf12c</a>><br style="">
> <br style="">
> Overall is LGTM, I would like to update the 2nd test message to something like<br style="">
> ’trace should not appear due to maxirconst limit’<br style="">
<br style="">
Fixed, see the iterative patch below.<br style="">
Branch is force-pushed.<br style="">
<br style="">
===================================================================<br style="">
diff --git a/test/tarantool-tests/lj-430-maxirconst.test.lua b/test/tarantool-tests/lj-430-maxirconst.test.lua<br style="">
index 79553ecb..10de2520 100644<br style="">
--- a/test/tarantool-tests/lj-430-maxirconst.test.lua<br style="">
+++ b/test/tarantool-tests/lj-430-maxirconst.test.lua<br style="">
@@ -38,6 +38,6 @@ irconst4()<br style="">
irconst4()<br style="">
jit.off()<br style="">
test:ok(ntrace_old == misc.getmetrics().jit_trace_num,<br style="">
- 'trace number is the same')<br style="">
+ 'trace should not appear due to maxirconst limit')<br style="">
<br style="">
os.exit(test:check() and 0 or 1)<br style="">
===================================================================<br style="">
<br style="">
> <br style="">
> Sergos<br style="">
> <br style="">
> > On 28 Jan 2022, at 15:35, Sergey Kaplun <<a href="mailto:skaplun@tarantool.org" style="">skaplun@tarantool.org</a>> wrote:<br style="">
> > <br style="">
> > Igor,<br style="">
> > <br style="">
> > On 28.01.22, Igor Munkin wrote:<br style="">
> >> Sergey,<br style="">
> >> <br style="">
> >> On 28.01.22, Sergey Kaplun wrote:<br style="">
> >>> Igor,<br style="">
> >>> <br style="">
> >>> Thanks for the review!<br style="">
> >>> <br style="">
> >> <br style="">
> >> <snipped><br style="">
> >> <br style="">
> >>>>> <br style="">
> >>>>> Issue: <a href="https://github.com/LuaJIT/LuaJIT/issues/430" target="_blank" style="">https://github.com/LuaJIT/LuaJIT/issues/430</a><br style="">
> >>>>> Branch: <a href="https://github.com/tarantool/luajit/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci" target="_blank" style="">https://github.com/tarantool/luajit/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci</a><br style="">
> >>>>> Tarantool branch: <a href="https://github.com/tarantool/tarantool/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci" target="_blank" style="">https://github.com/tarantool/tarantool/tree/skaplun/lj-430-maxirconst-actually-implement-full-ci</a><br style="">
> >>>>> <br style="">
> >>>>> src/lj_record.c | 5 ++-<br style="">
> >>>>> .../lj-430-maxirconst.test.lua | 43 +++++++++++++++++++<br style="">
> >>>>> 2 files changed, 46 insertions(+), 2 deletions(-)<br style="">
> >>>>> create mode 100644 test/tarantool-tests/lj-430-maxirconst.test.lua<br style="">
> >>>>> <br style="">
> >>>> <br style="">
> >>>> <snipped><br style="">
> >>>> <br style="">
> >>>>> diff --git a/test/tarantool-tests/lj-430-maxirconst.test.lua b/test/tarantool-tests/lj-430-maxirconst.test.lua<br style="">
> >>>>> new file mode 100644<br style="">
> >>>>> index 00000000..1829b37d<br style="">
> >>>>> --- /dev/null<br style="">
> >>>>> +++ b/test/tarantool-tests/lj-430-maxirconst.test.lua<br style="">
> >>>>> @@ -0,0 +1,43 @@<br style="">
> >>>>> +-- XXX: avoid any other traces compilation due to hotcount<br style="">
> >>>>> +-- collisions for predictible results.<br style="">
> >> <br style="">
> >> <snipped><br style="">
> >> <br style="">
> >>>>> +jit.off()<br style="">
> >>>>> +jit.flush()<br style="">
> >>>> <br style="">
> >>>> Minor: I'd rather move this part closer to 'jit.opt.start' to save the<br style="">
> >>>> test structure closer to the other test chunks. Feel free to ignore.<br style="">
> >>> <br style="">
> >>> I really want to exclude __any__ JIT work here to avoid false-positive<br style="">
> >>> hotcount (was precendents during writing this test :)). Ignoring.<br style="">
> >> <br style="">
> >> OK, got it.<br style="">
> >> <br style="">
> >>> <br style="">
> >> <br style="">
> >> <snipped><br style="">
> >> <br style="">
> >>>>> +test:ok(ntrace_old + 1 == misc.getmetrics().jit_trace_num,<br style="">
> >>>>> + 'trace number increases')<br style="">
> >>>> <br style="">
> >>>> Typo: I doubt we use tabs in Lua sources, but I might be wrong...<br style="">
> >>> <br style="">
> >>> I suggest to use quarter tabs indent style as we use for C code and Mike<br style="">
> >>> use in src/jit/*.lua (see bcsave.lua for example).<br style="">
> >>> <br style="">
> >>> There was no precedent before, IINM :).<br style="">
> >> <br style="">
> >> See test/tarantool-tests/lj-695-ffi-vararg-call.test.lua[1].<br style="">
> > <br style="">
> > Fixed, repushed.<br style="">
> > <br style="">
> >> <br style="">
> >>> <br style="">
> >>>> <br style="">
> >>>>> +<br style="">
> >>>>> +ntrace_old = misc.getmetrics().jit_trace_num<br style="">
> >>>>> +jit.on()<br style="">
> >>>>> +irconst4()<br style="">
> >>>>> +irconst4()<br style="">
> >>>>> +jit.off()<br style="">
> >>>>> +test:ok(ntrace_old == misc.getmetrics().jit_trace_num,<br style="">
> >>>>> + 'trace number is the same')<br style="">
> >>>> <br style="">
> >>>> Ditto.<br style="">
> >>>> <br style="">
> >>>>> +<br style="">
> >>>>> +os.exit(test:check() and 0 or 1)<br style="">
> >>>>> -- <br style="">
> >>>>> 2.34.1<br style="">
> >>>>> <br style="">
> >>>> <br style="">
> >>>> -- <br style="">
> >>>> Best regards,<br style="">
> >>>> IM<br style="">
> >>> <br style="">
> >>> -- <br style="">
> >>> Best regards,<br style="">
> >>> Sergey Kaplun<br style="">
> >> <br style="">
> >> [1]: <a href="https://github.com/tarantool/luajit/blob/tarantool/test/tarantool-tests/lj-695-ffi-vararg-call.test.lua" target="_blank" style="">https://github.com/tarantool/luajit/blob/tarantool/test/tarantool-tests/lj-695-ffi-vararg-call.test.lua</a><br style="">
> >> <br style="">
> >> -- <br style="">
> >> Best regards,<br style="">
> >> IM<br style="">
> > <br style="">
> > -- <br style="">
> > Best regards,<br style="">
> > Sergey Kaplun<br style="">
> <br style="">
<br style="">
-- <br style="">
Best regards,<br style="">
Sergey Kaplun</div>
<base target="_self" href="https://e.mail.ru/" style="">
</div>
</div></blockquote></div></div></BODY></HTML>