<HTML><BODY><div><div>Thanks for your review. New commit message:</div><div> </div><div><p><span> fiber: rename ref to storage_ref</span></p><p><span><span> </span></span></p><p><span><span> </span>Ref is a lua reference to fiber storage. This patch just renames</span></p><p><span><span> </span>storage.lua.ref to storage.lua.storage_ref to underline that</span></p><p><span><span> </span>it's not a reference to fiber itself and needed only for fiber</span></p><p><span><span> </span>storage.</span></p></div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 2 сентября 2021, 18:47 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16305976341499298339_BODY">Oleg,<br><br>Thanks for the patch! LGTM since the changes are trivial, but consider<br>the nits below.<br><br>On 11.08.21, <a href="/compose?To=olegrok@tarantool.org">olegrok@tarantool.org</a> wrote:<br>> From: Oleg Babin <<a href="/compose?To=babinoleg@mail.ru">babinoleg@mail.ru</a>><br>><br>> Ref is a lua reference to fiber storage. This patch just renames<br>> storage.lua.ref to storage_ref to underline that it's not a<br><br>Minor: This line seems ambiguous (at least to me). You're writing about<br>storage.lua.ref, so the renamed field should be storage.lua.storage_ref.<br>Feel free to ignore.<br><br>> reference to fiber itself and needed only for fiber storage.<br>> ---<br>> src/lib/core/fiber.h | 2 +-<br>> src/lua/fiber.c | 10 +++++-----<br>> 2 files changed, 6 insertions(+), 6 deletions(-)<br>><br>> diff --git a/src/lib/core/fiber.h b/src/lib/core/fiber.h<br>> index b85625ba7..593847df7 100644<br>> --- a/src/lib/core/fiber.h<br>> +++ b/src/lib/core/fiber.h<br>> @@ -626,7 +626,7 @@ struct fiber {<br>> /**<br>> * Optional fiber.storage Lua reference.<br>> */<br>> - int ref;<br>> + int storage_ref;<br><br>Typo: You're writing about <fiber_ref> in the commit subject, but the<br>patch is about <storage_ref>.<br><br>> } lua;<br>> /**<br>> * Iproto sync.<br><br><snipped><br><br>> --<br>> 2.32.0<br>><br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Babin</div></div></div><div> </div></div></BODY></HTML>