<HTML><BODY><div>QA lgtm</div><div> </div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Vitaliia Ioffe</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Пятница, 13 августа 2021, 19:08 +03:00 от Vladimir Davydov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16288709142106026748_BODY">On Fri, Aug 13, 2021 at 06:12:52AM +0300, <a href="/compose?To=imeevma@tarantool.org">imeevma@tarantool.org</a> wrote:<div class="mail-quote-collapse">> This patch reworks SCALAR and NUMBER types. Afther these patches SCANAR and<br>> NUMBER values will follow newly defined rules. However, only one SQL built-in<br>> function is actually changed in this patch. All other functions that should be<br>> changed will be reworked in issue #6105.<br>><br>> <a href="https://github.com/tarantool/tarantool/issues/6221" target="_blank">https://github.com/tarantool/tarantool/issues/6221</a><br>> <a href="https://github.com/tarantool/tarantool/tree/imeevma/gh-6221-introduce-mem-type-number" target="_blank">https://github.com/tarantool/tarantool/tree/imeevma/gh-6221-introduce-mem-type-number</a><br>><br>> Mergen Imeev (7):<br>> sql: remove enum field_type from struct Mem<br>> sql: re-introduce NUMBER and SCALAR meta-types<br>> sql: disallow implicit cast from NUMBER and SCALAR<br>> sql: disallow arithmetic for NUMBER and SCALAR<br>> sql: disallow bitwise for NUMBER and SCALAR<br>> sql: disallow concatination for SCALAR<br>> sql: fix comparison with SCALAR value</div><br>LGTM</div></div></div></div></blockquote><div> </div></BODY></HTML>