<div dir="ltr"><div dir="ltr"><div>Hi! Thank you for the patch. Find my comments below.<br></div><div><br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><span><div><div dir="ltr">Best regards</div><div>Yaroslav Dynnikov<br></div></div></span></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 13 Aug 2021 at 15:58, Vladimir Davydov <<a href="mailto:vdavydov@tarantool.org">vdavydov@tarantool.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Example output (for more examples see the test output):<br>
<br>
  tarantool> f = c:eval('return 123', {}, {is_async = true})<br>
  ---<br>
  ...<br>
<br>
  tarantool> tostring(f)<br>
  ---<br>
  - 'net.box.request: 7'<br>
  ...<br></blockquote><div><br></div><div>I think sync has no sense here. It's useless without other info (peer, function).</div><div>Also, it complicates the tests and makes them less reliable.</div><div>IMHO simple 'net.box.request' is enough.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
  tarantool> f<br>
  ---<br>
  - method: eval<br>
    on_push_ctx: []<br>
    result: [123]<br>
    on_push: 'function: builtin#91'<br>
    sync: 7<br>
  ...<br></blockquote><div><br></div><div>This is also weird:</div><div><br></div><div>tarantool> f<br>---<br>- on_push_ctx: []<br>  method: call<br>  sync: 4<br>  on_push: 'function: builtin#91'<br>...<br><br>tarantool> f.sync<br>---<br>- null<br>...<br><br>tarantool> f.method<br>---<br>- null<br>...</div><div><br></div><div>Why displaying inaccessible fields? You leave a developer no choice:</div><div><br></div><div>tarantool> debug.getmetatable(f).__serialize(f).method<br>---<br>- call<br>...<br><br></div><div>Of course, I miss that fields, but please, there should be another way to access them.</div><div><br></div><div>Also, speaking of <a href="https://github.com/tarantool/tarantool/commit/b996502b403c1698c4b0886de636faa0a63cfb70">https://github.com/tarantool/tarantool/commit/b996502b403c1698c4b0886de636faa0a63cfb70</a>,</div><div>which of them are you going to merge first? Whichever it is, I guess the second one is destined to be refactored afterward.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Closes #6314<br>
---<br>
<a href="https://github.com/tarantool/tarantool/issues/6314" rel="noreferrer" target="_blank">https://github.com/tarantool/tarantool/issues/6314</a><br>
<a href="https://github.com/tarantool/tarantool/tree/vdavydov/netbox-future-serialize" rel="noreferrer" target="_blank">https://github.com/tarantool/tarantool/tree/vdavydov/netbox-future-serialize</a><br>
<br>
</blockquote></div></div>