<HTML><BODY><div> </div><div>Hi, </div><div> </div><div>QA LGTM</div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Vitaliia Ioffe</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 4 августа 2021, 17:16 +03:00 от Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16280865991559926097_BODY">Hello,<br><br>On 04 авг 11:32, <a href="/compose?To=imeevma@tarantool.org">imeevma@tarantool.org</a> wrote:<div class="mail-quote-collapse">> This patch fixes the explicit cast to comply with the new rules. According to<br>> these rules, BOOLEAN and VARBINARY can no longer be cast to numeric types.<br>><br>> <a href="https://github.com/tarantool/tarantool/issues/4470" target="_blank">https://github.com/tarantool/tarantool/issues/4470</a><br>> <a href="https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-fix-explicit-cast" target="_blank">https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-fix-explicit-cast</a><br>><br>> Changes in v2:<br>> - Change of str_to_bool() were moved in new patch.<br>><br>> Mergen Imeev (3):<br>> sql: disallow explicit cast of BOOLEAN to number<br>> sql: disallow explicit cast of VARBINARY to number<br>> sql: fix STRING to BOOLEAN explicit cast</div><br>The patch set LGTM.<br><br>--<br>Regards, Kirill Yukhin</div></div></div></div></blockquote><div> </div></BODY></HTML>