<HTML><BODY><div>Hi! Thanks for the review!</div><div>Fix for the CMakeLists:</div><div>=========================================================================</div><div><div>diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt<br>index b9804033..ec08a19b 100644<br>--- a/test/lua-Harness-tests/CMakeLists.txt<br>+++ b/test/lua-Harness-tests/CMakeLists.txt<br>@@ -16,1 +16,1 @@ </div><div>-set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua\;${CMAKE_BINARY_DIR}/src/?.lua")<br>+set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua\;${LUAJIT_BINARY_DIR}/?.lua")</div></div><div>=========================================================================</div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 29 июля 2021, 12:45 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16275519570423543531_BODY">Max,<br><br>Thanks for the fixes! Just my two cents for the change below.<br><br>On 29.07.21, Максим Корякшин wrote:<br>><br>> Hi! Thanks for the review, Sergey!<br>> Here is the diff, which will add support of OOS build and will adjust<br>> comment in CMakeLists:<br>> ============================================================================================<br>> diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt<br>> index b9804033..90b4209a 100644<br>> --- a/test/lua-Harness-tests/CMakeLists.txt<br>> +++ b/test/lua-Harness-tests/CMakeLists.txt<br>> @@ -10,10 +10,10 @@ if(NOT PROVE)<br>> return()<br>> endif()<br>> -# Tests create temporary files (see 303-package.t for example)<br>> -# to require. Also, they require some files from original<br>> -# test source directory.<br>> -set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua")<br>> +# Tests create temporary files (see 303-package.t and 411-luajit.t for<br>> +# example) to require. Also, they require some files from original test<br>> +# source directory.<br><br>We try to box our comments up to 66 symbols. This is not a strict rule<br>anymore, but if you can follow this, please do. Feel free to ignore.<br><br>> +set(LUA_PATH "./?.lua\;${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;${LUAJIT_SOURCE_DIR}/?.lua\;${CMAKE_BINARY_DIR}/src/?.lua")<br><br>There is LUAJIT_BINARY_DIR variable, so please use either both<br>LUAJIT_*_DIR or CMAKE_*_DIR/src for consistency. BTW, consider the<br>difference between CMAKE_*_DIR and PROJECT_*_DIR, so I'm sure you need<br>the latter one.<br><br>> set(LUA_TEST_FLAGS --failures --shuffle)<br>> if(CMAKE_VERBOSE_MAKEFILE)<br>> ============================================================================================<br>> <br>> <br>> > <br><br><snipped><br><br>> > <br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote><div> </div></BODY></HTML>