<HTML><BODY><div>Hi! Thanks for the review, Sergey!</div><div>New commit message:</div><div>==============================================================</div><div><div> test: update lua-Harness to c4451fe</div><div> </div><div> This patch backports several small commits from the lua-Harness suite:<br> - follow ravi 1.0-beta4[1]<br> - refactor with near[2]<br> - follow LuaJIT[3]<br> - fix when no debug[4]<br> - check if luac exists[5]<br> - https[6]<br> - more assert[7]</div><div> </div><div> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/9455281b<br> [2]: https://framagit.org/fperrad/lua-Harness/-/commit/70404580<br> [3]: https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6<br> [4]: https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539<br> [5]: https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1<br> [6]: https://framagit.org/fperrad/lua-Harness/-/commit/673c7869<br> [7]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2">https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2</a></div><div> </div><div> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473<br>==============================================================</div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16274981930131159452_BODY">Hi, Maxim!<br><br>LGTM, except a single nitpick regarding the commit message.<br><br>On 26.07.21, Максим Корякшин wrote:<br>><br>> Thanks for the review, Igor!<br>> New commit message, considering your suggestions:<br>> =============================================================<br>> test: update lua-Harness to c4451fe<br>> <br>> This patch backports several small commits from lua-Harness suite:<br><br>Typo: s/from lua-Harness suite/from the lua-Harness suite/<br><br>> - follow ravi 1.0-beta4[1]<br>> - refactor with near[2]<br>> - follow LuaJIT[3]<br>> - fix when no debug[4]<br>> - check if luac exists[5]<br>> - https[6]<br>> - more assert[7]<br>> <br>> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/9455281b" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/9455281b</a><br>> [2]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/70404580" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/70404580</a><br>> [3]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6</a><br>> [4]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539</a><br>> [5]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1</a><br>> [6]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/673c7869" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/673c7869</a><br>> [7]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2</a><br>> <br>> Part of tarantool/tarantool#5970<br>> Part of tarantool/tarantool#4473<br>> <br>> =============================================================<br>> <br>> And here is the diff, which will add missing changes:<br>> =============================================================<br>> diff --git a/test/lua-Harness-tests/301-basic.t b/test/lua-Harness-tests/301-basic.t<br>> index 4adbb55c..e4ed2c41 100755<br>> --- a/test/lua-Harness-tests/301-basic.t<br>> +++ b/test/lua-Harness-tests/301-basic.t<br>> @@ -53,13 +53,15 @@ local lua = _retrieve_progname()<br>> plan'no_plan'<br>> do -- assert<br>> - local v, msg = assert('text', "assert string")<br>> + local v, msg, extra = assert('text', "assert string", 'extra')<br>> equals(v, 'text', "function assert")<br>> equals(msg, "assert string")<br>> - v, msg = assert({}, "assert table")<br>> + equals(extra, 'extra')<br>> + v, msg, extra = assert({}, "assert table", 'extra')<br>> equals(msg, "assert table")<br>> + equals(extra, 'extra')<br>> - error_matches(function () assert(false, "ASSERTION TEST") end,<br>> + error_matches(function () assert(false, "ASSERTION TEST", 'extra') end,<br>> "^[^:]+:%d+: ASSERTION TEST",<br>> "function assert(false, msg)")<br>> @@ -73,7 +75,7 @@ do -- assert<br>> else<br>> error_matches(function () assert(false, 42) end,<br>> "^[^:]+:%d+: 42",<br>> - "function assert(false, 42)")<br>> + "function assert(false, 42) --> invalid")<br>> end<br>> if has_error53 then<br>> =============================================================<br>> <br>> <br>> <br>> >Max,<br>> ><br>> >Thanks for the patch! Please consider the comments below.<br>> ><br>> >On 20.07.21, Maxim Kokryashkin wrote:<br>> >> This patch backports several small commits from lua-Harness suite:<br>> >> - follow ravi 1.0-beta4[1]<br>> >> - refactor with near[2]<br>> >> - follow LuaJIT[3]<br>> >> - fix when no debug[4]<br>> >> - check if luac exists[5]<br>> >> - https[6]<br>> >> - more assert[7]<br>> >><br>> >> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/9455281b" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/9455281b</a><br>> >> [2]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/70404580" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/70404580</a><br>> >> [3]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/ac7671b6</a><br>> >> [4]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/4db7e539</a><br>> >> [5]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/97e9e4c1</a><br>> >> [6]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/673c7869" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/673c7869</a><br>> >> [7]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/b7b1a9a2</a><br>> ><br>> >The changes from the latter commit is missing.<br>> ><br>> >Furthermore, you've updated lua-Harness up to c4451fe, which is<br>> >backported in scope of "[PATCH v2 01/10] test: port lua-Harness to<br>> >Test.Assertion". Hence, the commit subject need to be updated too.<br>> ><br>> >><br>> >> Part of #5970<br>> >> Part of #4473<br>> ><br>> >BTW, both issues are also mentioned the wrong way. The right format is<br>> >tarantool/tarantool#<issue-number> for both cases (see the previous<br>> >patches in the series for the examples).<br>> ><br>> >> ---<br>> >> test/lua-Harness-tests/200-examples.t | 2 +-<br>> >> test/lua-Harness-tests/203-lexico.t | 2 +-<br>> >> test/lua-Harness-tests/241-standalone.t | 3 +-<br>> >> test/lua-Harness-tests/242-luac.t | 4 +++<br>> >> test/lua-Harness-tests/301-basic.t | 2 +-<br>> >> test/lua-Harness-tests/304-string.t | 2 +-<br>> >> test/lua-Harness-tests/307-math.t | 44 +++++++++++------------<br>> >> test/lua-Harness-tests/310-debug.t | 2 --<br>> >> test/lua-Harness-tests/320-stdin.t | 14 +++++---<br>> >> test/lua-Harness-tests/401-bitop.t | 2 +-<br>> >> test/lua-Harness-tests/402-ffi.t | 2 +-<br>> >> test/lua-Harness-tests/403-jit.t | 2 +-<br>> >> test/lua-Harness-tests/404-ext.t | 2 +-<br>> >> test/lua-Harness-tests/411-luajit.t | 2 +-<br>> >> test/lua-Harness-tests/profile_ravi.lua | 4 +--<br>> >> test/lua-Harness-tests/test_assertion.lua | 9 +++++<br>> >> 16 files changed, 57 insertions(+), 41 deletions(-)<br>> >><br>> ><br>> ><snipped><br>> ><br>> >> --<br>> >> 2.32.0<br>> >><br>> ><br>> >--<br>> >Best regards,<br>> >IM<br>> <br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>