<HTML><BODY><div>Thanks for the review, Sergey!</div><div>Here is the new commit message, considering your comments:</div><div>====================================================================</div><div><div> test: use CI friendly variables in lua-Harness</div><div> </div><div> In the scope of the commit 45ed138dcb9228d8ac5b8d82331ddd20a0bfada1<br> ('test: set USERNAME env var for lua-Harness suite') the environment<br> of the testing process is tweaked via CMake, since both LOGNAME and<br> USERNAME environment variables might be missing.</div><div> </div><div> Actually, POSIX standard states that every user must have HOME<br> environment variable set. It allows to use this variable in<br> the corresponding assertion instead of LOGNAME and USERNAME without<br> additional environment setup.</div><div> </div><div> As a result this patch[1] from lua-Harness suite supersedes the<br> mentioned commit, and the CMake hack can be dropped.</div><div> </div><div> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87">https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87</a></div><div> </div><div> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473</div></div><div>====================================================================</div><div> </div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16273765910877099404_BODY">Hi, Maxim!<br><br>Thanks for the patch!<br>LGTM except a few nits regarding to the commit message.<br><br>===================================================================<br> test: use CI friendly variables in lua-Harness<br><br> In scope of the commit 45ed138dcb9228d8ac5b8d82331ddd20a0bfada1<br><br>Typo: s/In scope/In the scope/<br><br> ('test: set USERNAME env var for lua-Harness suite') the environment<br> of the testing process is tweaked via CMake, since both LOGNAME and<br> USERNAME environment variables might be missing.<br><br> Actually, POSIX standard states that every user must have HOME<br> environment variable set. It allows to use this in the corresponding<br><br>Typo? s/this/this variable/<br><br> assertion instead of LOGNAME and USERNAME without additional<br> environment setup.<br><br> As a result this patch[1] from lua-Harness suite supersedes the<br> mentioned commit, and CMake hack can be dropped.<br><br>Typo: s/CMake hack/the CMake hack/<br><br><br> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87</a><br><br> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473<br>===================================================================<br>On 26.07.21, Igor Munkin wrote:<div class="mail-quote-collapse">> Max,<br>><br>> Thanks for the fixes! LGTM.<br>><br>> --<br>> Best regards,<br>> IM</div><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>