<HTML><BODY><div>Thanks for the review, Sergey!</div><div>New commit message, with your comments in mind:</div><div>=================================================================</div><div><div> test: port lua-Harness to Test.Assertion</div><div> </div><div> Backports conversion to Test.Assertion patch[1] from the<br> lua-Harness suite.</div><div> </div><div> As a result of this change out-of-source testing is broken, but the<br> previous assertion using package.path as a second argument worked fine.<br> Because of that, this commit includes fix, that was made by this<br> patch[2] in the mainline lua-Harness.</div><div> </div><div> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/074fefa<br> [2]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe">https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe</a></div><div> </div><div> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473</div></div><div>=================================================================</div><div> <div> </div><div> </div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16273681421094924897_BODY">Hi!<br><br>Thanks for the patch!<br><br>LGTM, except a few nits regarding the commit message.<br><br>On 26.07.21, Максим Корякшин wrote:<br>><br>> Thanks for the review, Igor!<br>> Here is the new commit message with your suggestions in mind:<br>> ==========================================================<br>> test: port lua-Harness to Test.Assertion<br>> Backports conversion to Test.Assertion patch[1] from lua-Harness suite.<br><br>Typo: s/from lua-Harness suite/from the lua-Harness suite/<br><br>> As a result of this change out-of-source testing is broken, but the<br>> previous assertion using package.path as a second argument worked fine.<br>> Because of that, this commit includes fix, that was made by this patch[2]<br>> in mainline lua-Harness.<br><br>Nit: Missing optional empty line here.<br><br>> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/074fefa" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/074fefa</a><br>> [2]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe</a><br><br>Nit: Missing empty line here.<br><br>> Part of tarantool/tarantool#5970<br>> Part of tarantool/tarantool#4473<br>> <br>> ==========================================================<br>> <br>> <br>> <br>> >Igor Munkin wrote:<br>> > <br>> >Max,<br>> ><br>> >Thanks for the patch! LGTM, except the several nits.<br>> ><br>> >On 20.07.21, Maxim Kokryashkin wrote:<br>> >> Backports conversion to Test.Assertion patch[1] from lua-Harness suite<br>> ><br>> >Typo: Dot is missing at the end of the sentence.<br>> ><br>> >><br>> >> As a result out of this change out-of-source testing is broken, but the<br>> ><br>> >Typo: s/As a result out of/As a result of/.<br>> ><br>> >> previous assertion using package.path as a second argument worked fine.<br>> >> Because of that, this commit includes fix, that was made by this patch[2]<br>> >> in mainline lua-Harness.<br>> >><br>> >> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/074fefa51da1276078f735fa8fb568963fe541f1" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/074fefa51da1276078f735fa8fb568963fe541f1</a><br>> >> [2]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe06fcdc0d83a72dfa56eaae3ed26151c04" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/c4451fe06fcdc0d83a72dfa56eaae3ed26151c04</a><br>> ><br>> >Minor: You can strip commit hash in the links above up to 7 symbols to<br>> >shorted them a bit. Feel free to ignore.<br><br>Side note: I prefer the full commit hashes to avoid clashes, but never<br>mind :).<br><br>> ><br>> >><br>> >> Part of tarantool/tarantool#5970<br>> >> Part of tarantool/tarantool#4473<br>> >> ---<br>> >> Additional comments on issue with out-of-source testing:<br>> >> <a href="https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605" target="_blank">https://github.com/tarantool/tarantool/issues/5970#issuecomment-880158605</a><br>> >><br>> >> test/lua-Harness-tests/090-tap.t | 8 +-<br>> >> test/lua-Harness-tests/091-profile.t | 10 +-<br>> >> test/lua-Harness-tests/101-boolean.t | 126 +--<br>> >> test/lua-Harness-tests/102-function.t | 218 ++---<br>> >> test/lua-Harness-tests/103-nil.t | 126 +--<br>> >> test/lua-Harness-tests/104-number.t | 270 +++----<br>> >> test/lua-Harness-tests/105-string.t | 308 ++++----<br>> >> test/lua-Harness-tests/106-table.t | 132 ++--<br>> >> test/lua-Harness-tests/107-thread.t | 128 +--<br>> >> test/lua-Harness-tests/108-userdata.t | 124 +--<br>> >> test/lua-Harness-tests/200-examples.t | 12 +-<br>> >> test/lua-Harness-tests/201-assign.t | 82 +-<br>> >> test/lua-Harness-tests/202-expr.t | 138 ++--<br>> >> test/lua-Harness-tests/203-lexico.t | 66 +-<br>> >> test/lua-Harness-tests/204-grammar.t | 76 +-<br>> >> test/lua-Harness-tests/211-scope.t | 24 +-<br>> >> test/lua-Harness-tests/212-function.t | 138 ++--<br>> >> test/lua-Harness-tests/213-closure.t | 32 +-<br>> >> test/lua-Harness-tests/214-coroutine.t | 96 +--<br>> >> test/lua-Harness-tests/221-table.t | 54 +-<br>> >> test/lua-Harness-tests/222-constructor.t | 34 +-<br>> >> test/lua-Harness-tests/223-iterator.t | 18 +-<br>> >> test/lua-Harness-tests/231-metatable.t | 232 +++---<br>> >> test/lua-Harness-tests/232-object.t | 38 +-<br>> >> .../241-standalone.t.disabled | 116 +--<br>> >> test/lua-Harness-tests/242-luac.t | 80 +-<br>> >> test/lua-Harness-tests/301-basic.t | 748 +++++++++---------<br>> >> test/lua-Harness-tests/303-package.t | 119 +--<br>> >> test/lua-Harness-tests/304-string.t | 648 +++++++--------<br>> >> test/lua-Harness-tests/305-utf8.t | 4 +-<br>> >> test/lua-Harness-tests/306-table.t | 186 ++---<br>> >> test/lua-Harness-tests/307-math.t | 266 +++----<br>> >> test/lua-Harness-tests/308-io.t | 248 +++---<br>> >> test/lua-Harness-tests/309-os.t | 158 ++--<br>> >> test/lua-Harness-tests/310-debug.t | 226 +++---<br>> >> test/lua-Harness-tests/311-bit32.t | 70 +-<br>> >> test/lua-Harness-tests/314-regex.t | 8 +-<br>> >> test/lua-Harness-tests/320-stdin.t | 26 +-<br>> >> test/lua-Harness-tests/401-bitop.t | 60 +-<br>> >> test/lua-Harness-tests/402-ffi.t | 78 +-<br>> >> test/lua-Harness-tests/403-jit.t | 96 +--<br>> >> test/lua-Harness-tests/404-ext.t | 162 ++--<br>> >> test/lua-Harness-tests/411-luajit.t.disabled | 166 ++--<br>> >> test/lua-Harness-tests/lexico52/lexico.t | 22 +-<br>> >> test/lua-Harness-tests/lexico53/boolean.t | 44 +-<br>> >> test/lua-Harness-tests/lexico53/function.t | 72 +-<br>> >> test/lua-Harness-tests/lexico53/lexico.t | 14 +-<br>> >> test/lua-Harness-tests/lexico53/nil.t | 44 +-<br>> >> test/lua-Harness-tests/lexico53/number.t | 224 +++---<br>> >> test/lua-Harness-tests/lexico53/string.t | 196 ++---<br>> >> test/lua-Harness-tests/lexico53/table.t | 44 +-<br>> >> test/lua-Harness-tests/lexico53/thread.t | 44 +-<br>> >> test/lua-Harness-tests/lexico53/userdata.t | 44 +-<br>> >> test/lua-Harness-tests/lexico53/utf8.t | 240 +++---<br>> >> test/lua-Harness-tests/lexico54/lexico.t | 8 +-<br>> >> test/lua-Harness-tests/lexico54/metatable.t | 14 +-<br>> >> test/lua-Harness-tests/lexico54/utf8.t | 34 +-<br>> >> test/lua-Harness-tests/lexicojit/basic.t | 14 +-<br>> >> test/lua-Harness-tests/lexicojit/ext.t | 26 +-<br>> >> test/lua-Harness-tests/lexicojit/lexico.t | 30 +-<br>> >> test/lua-Harness-tests/tap.lua | 96 ++-<br>> >> 61 files changed, 3599 insertions(+), 3566 deletions(-)<br>> >><br>> ><br>> ><snipped><br>> ><br>> >> --<br>> >> 2.32.0<br>> >><br>> ><br>> >--<br>> >Best regards,<br>> >IM<br>> <br>> <br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></div></BODY></HTML>