<HTML><BODY><div>Thanks for the review, Sergey!</div><div>Here is the new commit message:</div><div>====================================================================</div><div><div> test: refactor with _retrieve_progname</div><div> </div><div> The patch[1] from the lua-Harness suite fixes the same issue as commit<br> 837688590919fcf8de47ef90479fd2a640c8fddc ('test: adjust lua-Harness<br> suite to CMake machinery') does except the single difference:<br> `get_lua_binary_name()` is called `_retrieved_progname()`. As a result<br> of this patch the function is renamed to follow the original naming.</div><div> </div><div> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8">https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8</a></div><div> </div><div> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473</div></div><div>====================================================================</div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16273781140404278497_BODY">Hi, Max!<br><br>Thanks for the patch!<br><br>LGTM, except several nitpicks regarding the commit message:<br>===================================================================<br> test: refactor with _retrieve_progname<br><br> The patch[1] from lua-Harness suite fixes the same issue commit<br><br>Typo: /from lua-Harness suite/from the lua-Harness suite/<br>Typo: /commit/as the commit/<br><br> <span class="js-phone-number">837688590919</span>fcf8de47ef90479fd2a640c8fddc ('test: adjust lua-Harness<br> suite to CMake machinery') does except the single difference:<br> `get_lua_binary_name()` is called `_retrieved_progname()`. As a result<br> of this patch the function is renamed to follow the original naming.<br><br> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/1be25a8</a><br><br> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473<br>===================================================================<br><br>On 26.07.21, Igor Munkin wrote:<div class="mail-quote-collapse">> Max,<br>><br>> Thanks for the fixes! LGTM.<br>><br>> --<br>> Best regards,<br>> IM<br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>><br>></div><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></div></blockquote></BODY></HTML>