<HTML><BODY><div>Thanks for the review, Igor!</div><div>Here’s the new commit message with all changes made:</div><div>===============================================</div><div><div> test: support tarantool in lua-Harness</div><div> Backports 'support Tarantool' patch[1] from lua-Harness.<br> This patch introduces lua-Harness profile for Tarantool considering the<br> platform specifics. Furthermore, these changes skip all CLI-related<br> tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be<br> renamed back.</div><div> [1]: https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16</div><div> Part of tarantool/tarantool#5970<br> Part of tarantool/tarantool#4473<br> </div></div><div>===============================================</div><div> <div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 26 июля 2021, 0:35 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16272489281527289995_BODY">Max,<br><br>Thanks for the patch! The changes are fine, so no comments regarding<br>them, but please consider the nit regarding the commit message.<br><br>On 20.07.21, Maxim Kokryashkin wrote:<br>> Backports 'supoort Tarantool' patch[1] from lua-Harness.<br><br>Please, describe the changes in details. E.g. it's worth to mention that<br>this patch introduces lua-Harness profile for Tarantool considering the<br>platform specifics. Furthermore, these changes skips all CLI-related<br>tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be<br>renamed back.<br><br>><br>> [1]: <a href="https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16" target="_blank">https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16</a><br>><br>> Part of tarantool/tarantool#5970<br>> Part of tarantool/tarantool#4473<br>> ---<br>> ...standalone.t.disabled => 241-standalone.t} | 5 ++<br>> test/lua-Harness-tests/320-stdin.t | 2 +-<br>> .../{411-luajit.t.disabled => 411-luajit.t} | 2 +-<br>> test/lua-Harness-tests/profile_tarantool.lua | 63 +++++++++++++++++++<br>> 4 files changed, 70 insertions(+), 2 deletions(-)<br>> rename test/lua-Harness-tests/{241-standalone.t.disabled => 241-standalone.t} (99%)<br>> rename test/lua-Harness-tests/{411-luajit.t.disabled => 411-luajit.t} (99%)<br>> create mode 100644 test/lua-Harness-tests/profile_tarantool.lua<br>><br><br><snipped><br><br>> --<br>> 2.32.0<br>><br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote><div> </div></div></BODY></HTML>