<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi, thank you for the review! <br>
</p>
<div class="moz-cite-prefix">05.03.2021 15:44, Leonid Vasiliev
пишет:<br>
</div>
<blockquote type="cite"
cite="mid:6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org">Hi!
<br>
Please, add changelogs according to `doc/changelogs.md`.
<br>
</blockquote>
Done. Added <a
title="changelogs/unreleased/fix-tarantool-e-option.md"
class="Link--primary"
href="https://github.com/tarantool/tarantool/commit/fe750e977b30ca41975af9b78e56f70202c3024c#diff-c7ab331bb2558e469c1851f9d09ea8be0157b129af12a2370d2fbe77a12a378d"
style="box-sizing: border-box; color: var(--color-text-primary)
!important; text-decoration: none; caret-color: rgb(36, 41, 46);
font-family: SFMono-Regular, Consolas, "Liberation
Mono", Menlo, monospace; font-size: 12.000000953674316px;
font-style: normal; font-variant-caps: normal; font-weight:
normal; letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px;">changelogs/unreleased/fix-tarantool-e-option.md</a>
<blockquote type="cite"
cite="mid:6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org">
<br>
On 3/4/21 12:15 PM, Artem Starshov wrote:
<br>
<blockquote type="cite">Issue:
<a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/issues/5040">https://github.com/tarantool/tarantool/issues/5040</a>
<br>
Branch:
<a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug">https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug</a><br>
CI: <a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/runs/2029377964">https://github.com/tarantool/tarantool/runs/2029377964</a>
<br>
<br>
Changes in v3:
<br>
* core:
<br>
- add case-insensetive value for boolean error injection;
<br>
- add more tests for setting error injections;
<br>
- few refactored things (80 line width, alignment and
etc.);
<br>
- add release_disable for test;
<br>
- add reference to test-run issue in commit message;
<br>
- now, it is able to set errinjs via env ONLY in Debug
mode.
<br>
* lua:
<br>
- some refactoring (name of variables, 80 line-width..);
<br>
- add release_disable for test;
<br>
- add reference to test-run issue in commit message;
<br>
- add "errinj" to the name of the test;
<br>
- add comments to source code.
<br>
<br>
Artem Starshov (2):
<br>
core: add setting error injections via env
<br>
lua: fix tarantool -e always enters interactive mode
<br>
<br>
src/lib/core/errinj.c | 30 +++++
<br>
src/lib/core/errinj.h | 6 +
<br>
src/lua/init.c | 27 +++-
<br>
src/main.cc | 3 +
<br>
...5040-inter-mode-isatty-via-errinj.test.lua | 126
++++++++++++++++++
<br>
test/app-tap/suite.ini | 1 +
<br>
.../errinj_set_with_enviroment_vars.test.lua | 29 ++++
<br>
...errinj_set_with_enviroment_vars_script.lua | 34 +++++
<br>
test/box-tap/suite.ini | 1 +
<br>
test/box/errinj.result | 1 +
<br>
10 files changed, 254 insertions(+), 4 deletions(-)
<br>
create mode 100755
test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua
<br>
create mode 100755
test/box-tap/errinj_set_with_enviroment_vars.test.lua
<br>
create mode 100644
test/box-tap/errinj_set_with_enviroment_vars_script.lua
<br>
<br>
</blockquote>
</blockquote>
</body>
</html>